Skip to content

serde feature and traits implementation for Arc#2

Merged
taiki-e merged 4 commits into
taiki-e:mainfrom
tommasoclini:serde
Apr 16, 2026
Merged

serde feature and traits implementation for Arc#2
taiki-e merged 4 commits into
taiki-e:mainfrom
tommasoclini:serde

Conversation

@tommasoclini

@tommasoclini tommasoclini commented Apr 5, 2026

Copy link
Copy Markdown
Contributor

Closes #1

@taiki-e taiki-e left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Comment thread Cargo.toml Outdated
Comment thread Cargo.toml Outdated
@tommasoclini

Copy link
Copy Markdown
Contributor Author

How do I allow sede::{Serialize, Deserialize} as external types?

@taiki-e

taiki-e commented Apr 7, 2026

Copy link
Copy Markdown
Owner

It would be best to do the same thing that portable-atomic does:

@tommasoclini

Copy link
Copy Markdown
Contributor Author

Is it ok now?

@taiki-e

taiki-e commented Apr 15, 2026

Copy link
Copy Markdown
Owner

Could you address the remaining CI failures?
Since all errors are in diff form, I think applying the fixes will be easy.
https://github.com/taiki-e/portable-atomic-util/actions/runs/24204227961/job/70655797351?pr=2

@taiki-e taiki-e left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@taiki-e taiki-e merged commit b9e3ad8 into taiki-e:main Apr 16, 2026
33 checks passed
@tommasoclini

Copy link
Copy Markdown
Contributor Author

Getting this to merge was a learning experience 😂, in a positive way though.

@taiki-e

taiki-e commented Apr 16, 2026

Copy link
Copy Markdown
Owner

Published in 0.2.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feature request: serde traits implementation for Arc

2 participants