Skip to content

chore(tools): add cargo-auditable#741

Merged
taiki-e merged 10 commits intotaiki-e:mainfrom
simonsan:chore/tools/cargo-auditable
Nov 19, 2024
Merged

chore(tools): add cargo-auditable#741
taiki-e merged 10 commits intotaiki-e:mainfrom
simonsan:chore/tools/cargo-auditable

Conversation

@simonsan
Copy link
Contributor

Closes #740

Signed-off-by: simonsan <14062932+simonsan@users.noreply.github.com>
Copy link
Owner

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

simonsan and others added 3 commits November 11, 2024 14:49
Co-authored-by: Taiki Endo <te316e89@gmail.com>
Co-authored-by: Taiki Endo <te316e89@gmail.com>
Signed-off-by: simonsan <14062932+simonsan@users.noreply.github.com>
@simonsan
Copy link
Contributor Author

Regenerated the manifest, should be ready to go. 👍🏽

@taiki-e
Copy link
Owner

taiki-e commented Nov 11, 2024

It seems to be failing in Windows.

https://github.com/taiki-e/install-action/actions/runs/11779914031/job/32809380176?pr=741#step:8:51

info: installing cargo-auditable@latest
info: downloading https://github.com/rust-secure-code/cargo-auditable/releases/download/v0.6.4/cargo-auditable-x86_64-pc-windows-msvc.zip
info: verifying sha256 checksum for cargo-auditable-x86_64-pc-windows-msvc.zip
caution: filename not matched:  cargo-auditable-x86_64-pc-windows-msvc/cargo-auditable.exe

(I think failures in test-container is an issue that needs to be addressed on my end.)

Signed-off-by: simonsan <14062932+simonsan@users.noreply.github.com>
@simonsan
Copy link
Contributor Author

Should be fixed with the latest commit, it seems the folder hierarchy is different in the zip than the other one's ...

@taiki-e
Copy link
Owner

taiki-e commented Nov 19, 2024

(I think failures in test-container is an issue that needs to be addressed on my end.)

I found out that this is actually not a problem on our end, but because cargo-auditable does not support --version flag and tries to forward the input to Cargo in all cases.

For example, in the following case, the output shows the version of Cargo, not the version of cargo-auditable itself.

https://github.com/taiki-e/install-action/actions/runs/11790926857/job/32842147226#step:8:72

+ cargo-auditable auditable --version
cargo 1.82.0 (8f40fc59f 2024-08-21)

@simonsan Could you add cargo-auditable to the following branch to address this issue?

install-action/main.sh

Lines 792 to 793 in f725b9a

# these packages support neither --version nor --help flag.
cargo-careful | wasm-bindgen-test-runner) ;;

@simonsan
Copy link
Contributor Author

Added it 👍🏽

@taiki-e
Copy link
Owner

taiki-e commented Nov 19, 2024

Thanks. I think the remaining CI failure will be fixed by regenerating the manifest.

Signed-off-by: simonsan <14062932+simonsan@users.noreply.github.com>
@taiki-e taiki-e merged commit 6662e50 into taiki-e:main Nov 19, 2024
@taiki-e
Copy link
Owner

taiki-e commented Nov 19, 2024

Published in 2.45.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add to supported tools: cargo-auditable

2 participants