Skip to content

feat: custom features support#9

Merged
taiki-e merged 4 commits intotaiki-e:mainfrom
AlexTMjugador:feat/features-support
Jul 22, 2025
Merged

feat: custom features support#9
taiki-e merged 4 commits intotaiki-e:mainfrom
AlexTMjugador:feat/features-support

Conversation

@AlexTMjugador
Copy link
Copy Markdown
Contributor

This PR resolves #7 by implementing action inputs that allow customizing the --features, --all-features, and --no-default-features CLI flags that get passed to cargo install. If such inputs are not set, the specified tool is installed with its default feature set, as it was done before. I've tested the changes to work as expected on a production CI workflow.

@AlexTMjugador
Copy link
Copy Markdown
Contributor Author

AlexTMjugador commented Jun 12, 2025

The Windows CI checks where the default Bash shell is replaced by Cygwin's are failing with a line 9: syntax error near unexpected token $'\r'' error. This issue is unrelated to this PR, and I'm puzzled as to why it's happening, especially since the .gitattributes file specifies that all text files should be checked out with LF line endings. On the main branch, these checks seem to pass due to a cache hit, which does not occur for pull requests.

I'm unsure whether I should attempt to address this failure within this PR. Overall, testing such a specific Bash shell override with Cygwin feels, in the context of this action, very odd, as I see few practical scenarios where someone would want to override GITHUB_PATH to use it. People using custom runners with such a shell configuration will likely realize that the issue is with their environment and resolve it themselves (it's very likely that other similar actions won't work anyway). I tried tweaking gitattributes in the force-pushes I did to no avail.

Please let me know your thoughts on how to proceed with this PR!

@taiki-e taiki-e force-pushed the main branch 2 times, most recently from 84cd917 to 416e06a Compare June 29, 2025 14:47
Copy link
Copy Markdown
Owner

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@taiki-e taiki-e merged commit 361800f into taiki-e:main Jul 22, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add features, no-default-features, and all-features input options

2 participants