fix: detect whether to use jq -b correctly on Windows#15
Merged
taiki-e merged 2 commits intotaiki-e:mainfrom Jan 9, 2026
Merged
fix: detect whether to use jq -b correctly on Windows#15taiki-e merged 2 commits intotaiki-e:mainfrom
jq -b correctly on Windows#15taiki-e merged 2 commits intotaiki-e:mainfrom
Conversation
Owner
|
Published in v3.0.1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reverts #12 and applies a correct fix for #12 (comment).
The Bash bundled with Git for Windows removes trailing
\rfrom value in variable assignment:This patch results in the following different behavior which makes the comparison that tries to detect
null\ralways fail:In order to correctly detect this case, I rewrote that part without variable assignment on MSYS2 Bash: