Skip to content

[Lang] Fix string format not support keywords format#3256

Merged
ailzhang merged 2 commits intotaichi-dev:masterfrom
yihong0618:master
Oct 25, 2021
Merged

[Lang] Fix string format not support keywords format#3256
ailzhang merged 2 commits intotaichi-dev:masterfrom
yihong0618:master

Conversation

@yihong0618
Copy link
Contributor

@yihong0618 yihong0618 commented Oct 23, 2021

Related issue = #2552

test here

@ti.kernel
def func(k: ti.f32):
    print(123)
    print("{} abc".format(123))
    print("{} {} {}".format(1, 2, 3))
    print("{} {name} {value}".format(k, name=999, value=123))
    name = 123.4
    value = 456.7
    print("{} {name} {value}".format(k, name=name, value=value))

func(233.3)

@netlify
Copy link

netlify bot commented Oct 23, 2021 •
edited
Loading

✔️ Deploy Preview for jovial-fermat-aa59dc canceled.

🔨 Explore the source changes: 1ff57c0

🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-fermat-aa59dc/deploys/61738970e7f89300078bedea

@k-ye k-ye requested a review from Leonz5288 October 23, 2021 12:27
ailzhang
ailzhang approved these changes Oct 25, 2021
View reviewed changes
Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Leonz5288
Leonz5288 approved these changes Oct 25, 2021
View reviewed changes
Copy link
Contributor

@Leonz5288 Leonz5288 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ailzhang ailzhang merged commit fac2118 into taichi-dev:master Oct 25, 2021
@yihong0618 yihong0618 mentioned this pull request Mar 21, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@ailzhang ailzhang ailzhang approved these changes

@Leonz5288 Leonz5288 Leonz5288 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yihong0618 @ailzhang @Leonz5288