Fix #469 - parsing from buffered reader#471
Merged
Mingun merged 2 commits intotafia:masterfrom Sep 10, 2022
Merged
Conversation
failures (8):
reader::async_tokio::test::small_buffers::cdata1
reader::async_tokio::test::small_buffers::cdata2
reader::async_tokio::test::small_buffers::comment1
reader::async_tokio::test::small_buffers::comment2
reader::buffered_reader::test::small_buffers::cdata1
reader::buffered_reader::test::small_buffers::cdata2
reader::buffered_reader::test::small_buffers::comment1
reader::buffered_reader::test::small_buffers::comment2
… the boundary of chunks in buffered reader The bug was introduced in f2b99f0
Collaborator
Author
|
I'm going to merge this soon and release 0.25.0 with the fix |
Closed
Collaborator
|
That's fine. I had a brief look at it but hadn't did a comprehensive review yet. My amount of free time varies week to week. Some automated fuzzing would probably be effective at rooting out issues like this. |
Collaborator
|
It would be good to set guidelines for which bugs are severe enough to trigger a yank. I'm not sure that it was worthwhile in this case |
Collaborator
Author
|
The problem in that that this bug can hide some content from reader if XML will be carefully constructed, which can have security implications. That is why I decided to yank that versions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #469
The bug was introduced in f2b99f0.