Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the curb gem to be compatible with Ruby 4.1.0dev by replacing the deprecated rb_iterate API with rb_block_call. The rb_iterate function was removed from Ruby HEAD (issue #21768), causing build failures. This change maintains functional equivalence while using the modern Ruby C API.
Changes:
- Replaced 4 occurrences of
rb_iterate(rb_each, ...)withrb_block_call(..., rb_intern("each"), ...) - Updated calls for headers, proxy_headers, ftp_commands, and resolve list iteration
Comments suppressed due to low confidence (4)
ext/curb_easy.c:2248
- The comment states this is an 'rb_iterate callback' but the code now uses
rb_block_call. Update the comment to reflect that this is anrb_block_callcallback or simply a callback function.
/***********************************************
* This is an rb_iterate callback used to set up http headers.
*/
ext/curb_easy.c:2287
- The comment states this is an 'rb_iterate callback' but the code now uses
rb_block_call. Update the comment to reflect that this is anrb_block_callcallback or simply a callback function.
/***********************************************
* This is an rb_iterate callback used to set up http proxy headers.
*/
ext/curb_easy.c:2323
- The comment states this is an 'rb_iterate callback' but the code now uses
rb_block_call. Update the comment to reflect that this is anrb_block_callcallback or simply a callback function.
/***********************************************
* This is an rb_iterate callback used to set up ftp commands.
*/
ext/curb_easy.c:2341
- The comment states this is an 'rb_iterate callback' but the code now uses
rb_block_call. Update the comment to reflect that this is anrb_block_callcallback or simply a callback function.
/***********************************************
* This is an rb_iterate callback used to set up the resolve list.
*/
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ruby 4.1.0dev couldn't build
curbgem.rb_iteratehas been removed from ruby HEAD: https://bugs.ruby-lang.org/issues/21768I replaced that to
rb_block_call.