Added email, fixed typos#2
Merged
tacaswell merged 2 commits intotacaswell:cpython_support_nepfrom Jul 19, 2019
Merged
Conversation
Owner
|
Thanks @mdhaber ! |
Author
|
@tacaswell Thoughts on those other items? I can help fix them in another PR if you agree. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I limited this PR to 100% objective changes (I hope).
A few other things to consider:
numpy. Currently it is "Numpy" in the title and numpy/numpythroughout, but there seems to be some preference for "NumPy" when not in teletype.+from each year. It would make more sense to me if the+/|symbols each represented a month (rather than the visual gap between adjacent symbols representing a month).or shorter than 24 months." Does this mean "adopt a time window of 24 months or shorter"?
Thanks for drafting this!