Make polar day and polar night wallpapers more accurate#545
Make polar day and polar night wallpapers more accurate#545lulunac27a wants to merge 6 commits intot1m0thyj:mainfrom lulunac27a:main
Conversation
Add SolarNoon in SolarTimes
Make polar day/polar night wallpaper more accurate based on solar noon times https://stackoverflow.com/questions/1489243/how-can-i-convert-ticks-to-a-date-format https://stackoverflow.com/questions/14415753/wrap-value-into-range-min-max-without-division
Make polar day/polar night themes work all day long
|
@lulunac27a Thanks for your contribution and bringing this issue to my attention! The changes made in this PR seem to only affect the theme preview dialog. There is also some code in SolarScheduler.cs that would need to be changed for the wallpaper scheduler to respect solar noon: WinDynamicDesktop/src/SolarScheduler.cs Lines 163 to 172 in a0b1c87 I've changed this in 06825b3 and fb65795 - tried to make wallpapers more accurate for polar day and night, and added some unit tests to verify solar noon is being handled correctly. Could you download a test build from here and let me know if it works as expected? (EXE is portable version, MSIX is Store app) |
|
This behavior should now be fixed in WinDD 5.4.1 to show the brightest wallpaper at solar noon. |
The brightest wallpaper for polar day and polar night is at solar noon (approximately noon or 1pm local time, which is the highest point of the sun)