Remove WP_CLI from the dynamicConstantNames list#288
Merged
szepeviktor merged 1 commit intoszepeviktor:2.xfrom Jul 7, 2025
Merged
Remove WP_CLI from the dynamicConstantNames list#288szepeviktor merged 1 commit intoszepeviktor:2.xfrom
WP_CLI from the dynamicConstantNames list#288szepeviktor merged 1 commit intoszepeviktor:2.xfrom
Conversation
Owner
|
@IanDelMar Thank you. Have you ever seen |
Contributor
Author
|
No, I have not. It is just an example. Any fetch will result in the aforementioned fatal error if |
Owner
|
I would leave it as is. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the
WP_CLIconstant from thedynamicConstantNameslist inextension.neon, as it is not defined by WordPress (see this GitHub search), but rather by WP-CLI.Including
WP_CLIin thedynamicConstantNameslist prevents PHPStan from reporting the following code:If
WP_CLIis not defined, this will trigger a fatal error in PHP 8+.Those using WP-CLI can easily add the
WP_CLIconstant to their own configuration. Therefore, this package should not prevent PHPStan from reporting potential fatal errors for some users.Related #287