Skip to content

Add WP_LANG_DIR constant#212

Merged
szepeviktor merged 1 commit intoszepeviktor:masterfrom
swissspidy:add/wp-lang-dir
Feb 26, 2024
Merged

Add WP_LANG_DIR constant#212
szepeviktor merged 1 commit intoszepeviktor:masterfrom
swissspidy:add/wp-lang-dir

Conversation

@swissspidy
Copy link
Copy Markdown
Contributor

@swissspidy swissspidy commented Feb 26, 2024

Defined in wp_set_lang_dir().

There is no function to read this constant.

Related:

@szepeviktor
Copy link
Copy Markdown
Owner

szepeviktor commented Feb 26, 2024 •
edited
Loading

There is no function to read this constant.

And you should not read that constant.

@szepeviktor szepeviktor merged commit 3a8e8a9 into szepeviktor:master Feb 26, 2024
@johnbillion
Copy link
Copy Markdown
Contributor

johnbillion commented Feb 26, 2024

Should this go into dynamicConstantNames too?

@szepeviktor
Copy link
Copy Markdown
Owner

szepeviktor commented Feb 26, 2024

Should this go into dynamicConstantNames too?

No, this is always a non-empty string - PHPStan does not care what its value is.

@swissspidy swissspidy deleted the add/wp-lang-dir branch February 26, 2024 13:54
@szepeviktor
Copy link
Copy Markdown
Owner

szepeviktor commented Feb 26, 2024

Pascal must have a special plugin that is fiddling with translations...

@swissspidy
Copy link
Copy Markdown
Contributor Author

swissspidy commented Feb 26, 2024

Hehe just working on adding PHPStan to my Preferred Languages plugin :) swissspidy/preferred-languages#961

@gritdigital-mibu
Copy link
Copy Markdown

gritdigital-mibu commented Mar 13, 2024

Having this issue with WP_CONTENT_DIR too. WP core just refers directly to the constant / no function to read. 🫠

@gritdigital-mibu
Copy link
Copy Markdown

gritdigital-mibu commented Mar 13, 2024

There is WP_Filesystem_Base::wp_content_dir() but it's not available where I need it. Anyways, I'm rambling. 😅

@swissspidy
Copy link
Copy Markdown
Contributor Author

swissspidy commented Mar 13, 2024

@gritdigital-mibu Feel free to submit a PR for WP_CONTENT_DIR :)

@westonruter westonruter mentioned this pull request Mar 21, 2024
Merged
@westonruter
Copy link
Copy Markdown
Contributor

westonruter commented Mar 21, 2024

Feel free to submit a PR for WP_CONTENT_DIR :)

Proposed in #216

@szepeviktor
Copy link
Copy Markdown
Owner

szepeviktor commented Mar 21, 2024

@gritdigital-mibu You've got a new release.
https://github.com/szepeviktor/phpstan-wordpress/releases/tag/v1.3.4

@gritdigital-mibu
Copy link
Copy Markdown

gritdigital-mibu commented Apr 2, 2024

Fab.! Ty ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@swissspidy @szepeviktor @johnbillion @gritdigital-mibu @westonruter