Add test for WpThemeMagicPropertiesClassReflectionExtension#206
Merged
szepeviktor merged 3 commits intoszepeviktor:masterfrom Nov 1, 2023
Merged
Add test for WpThemeMagicPropertiesClassReflectionExtension#206szepeviktor merged 3 commits intoszepeviktor:masterfrom
szepeviktor merged 3 commits intoszepeviktor:masterfrom
Conversation
Owner
|
Thank you. |
szepeviktor
requested changes
Nov 1, 2023
szepeviktor
reviewed
Nov 1, 2023
Co-authored-by: Viktor Szépe <viktor@szepe.net>
Owner
|
🎵 Payment for the PR: Shamisen plunking 🇯🇵 https://www.youtube.com/watch?v=RcqO0zkyQRo |
Contributor
Author
|
Very generous! 👯 |
Owner
|
... we could have a non-existent property - but do not worry about it |
Contributor
Author
|
Do you mean that |
Contributor
Author
|
But now I'm wondering why we don't add them via the stubs' functionMap. |
Owner
|
I've meant to add a line like |
Contributor
Author
Owner
|
You see?? The PR is longer than 1 line so viktor is 😵 confuzed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.