Skip to content

Add test for WpThemeMagicPropertiesClassReflectionExtension#206

Merged
szepeviktor merged 3 commits intoszepeviktor:masterfrom
IanDelMar:wptheme-props
Nov 1, 2023
Merged

Add test for WpThemeMagicPropertiesClassReflectionExtension#206
szepeviktor merged 3 commits intoszepeviktor:masterfrom
IanDelMar:wptheme-props

Conversation

@IanDelMar
Copy link
Copy Markdown
Contributor

No description provided.

@szepeviktor
Copy link
Copy Markdown
Owner

Thank you.

Co-authored-by: Viktor Szépe <viktor@szepe.net>
@szepeviktor
Copy link
Copy Markdown
Owner

🎵 Payment for the PR: Shamisen plunking 🇯🇵 https://www.youtube.com/watch?v=RcqO0zkyQRo

@szepeviktor szepeviktor merged commit 2e08b58 into szepeviktor:master Nov 1, 2023
@IanDelMar
Copy link
Copy Markdown
Contributor Author

Very generous! 👯

@szepeviktor
Copy link
Copy Markdown
Owner

... we could have a non-existent property - but do not worry about it

@IanDelMar
Copy link
Copy Markdown
Contributor Author

Do you mean that WP_Theme does not necessarily have all of these properties? I var_dumped all properties of a theme where I removes all info from style.css except the name of the theme. All properties get populated at least with an empty string or an empty array.

@IanDelMar
Copy link
Copy Markdown
Contributor Author

But now I'm wondering why we don't add them via the stubs' functionMap.

@szepeviktor
Copy link
Copy Markdown
Owner

I've meant to add a line like

['WP_Theme', 'gluegun', false],

@IanDelMar
Copy link
Copy Markdown
Contributor Author

@szepeviktor
Copy link
Copy Markdown
Owner

You see?? The PR is longer than 1 line so viktor is 😵 confuzed!

@IanDelMar IanDelMar deleted the wptheme-props branch August 30, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants