Skip to content

changed the extension of mztabm to ".mzTab"#683

Merged
Bujee415 merged 1 commit intomasterfrom
change_mztabextension
Dec 16, 2025
Merged

changed the extension of mztabm to ".mzTab"#683
Bujee415 merged 1 commit intomasterfrom
change_mztabextension

Conversation

@htsugawa
Copy link
Copy Markdown
Contributor

No description provided.

@Bujee415 Bujee415 merged commit 327e55d into master Dec 16, 2025
12 of 13 checks passed
@Bujee415 Bujee415 deleted the change_mztabextension branch December 16, 2025 02:10
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR standardizes the file extension for mzTab-M format exports from ".mzTabM" and ".mzTab.txt" to ".mzTab" across the codebase.

  • Changed file extension from ".mzTabM" to ".mzTab" in test process files
  • Simplified the GUI export file extension from ".mzTab.txt" to ".mzTab"

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
tests/MSDIAL5/MsdialCoreTestApp/Process/LcmsProcess.cs Updated mzTab file extension from ".mzTabM" to ".mzTab" for LC-MS process
tests/MSDIAL5/MsdialCoreTestApp/Process/LcimmsProcess.cs Updated mzTab file extension from ".mzTabM" to ".mzTab" for LC-IM-MS process
tests/MSDIAL5/MsdialCoreTestApp/Process/ImmsProcess.cs Updated mzTab file extension from ".mzTabM" to ".mzTab" for IM-MS process
tests/MSDIAL5/MsdialCoreTestApp/Process/GcmsProcess.cs Updated mzTab file extension from ".mzTabM" to ".mzTab" for GC-MS process
tests/MSDIAL5/MsdialCoreTestApp/Process/DimsProcess.cs Updated mzTab file extension from ".mzTabM" to ".mzTab" for DIMS process
src/MSDIAL5/MsdialGuiApp/Model/Export/AlignmentMztabMExportModel.cs Simplified exported filename template from ".mzTab.txt" to ".mzTab"

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

align_mspexporter.BatchExport(streammsp, result.AlignmentSpotProperties, align_decResults);

var mztabm_filename = alignmentFile.FileName + ".mzTabM";
var mztabm_filename = alignmentFile.FileName + ".mzTab";
Copy link

Copilot AI Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable name 'mztabm_filename' still contains 'mztabm' but now stores a filename with '.mzTab' extension. Consider renaming this variable to 'mztab_filename' to better reflect its content and maintain consistency with the new extension naming convention.

Copilot uses AI. Check for mistakes.
align_mspexporter.BatchExport(streammsp, result.AlignmentSpotProperties, align_decResults);

var mztabm_filename = alignmentFile.FileName + ".mzTabM";
var mztabm_filename = alignmentFile.FileName + ".mzTab";
Copy link

Copilot AI Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable name 'mztabm_filename' still contains 'mztabm' but now stores a filename with '.mzTab' extension. Consider renaming this variable to 'mztab_filename' to better reflect its content and maintain consistency with the new extension naming convention.

Copilot uses AI. Check for mistakes.
align_mspexporter.BatchExport(streammsp, result.AlignmentSpotProperties, align_decResults);

var mztabm_filename = alignmentFile.FileName + ".mzTabM";
var mztabm_filename = alignmentFile.FileName + ".mzTab";
Copy link

Copilot AI Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable name 'mztabm_filename' still contains 'mztabm' but now stores a filename with '.mzTab' extension. Consider renaming this variable to 'mztab_filename' to better reflect its content and maintain consistency with the new extension naming convention.

Copilot uses AI. Check for mistakes.
spotExporter.Export(stream, result.AlignmentSpotProperties, decResults, files, new MulticlassFileMetaAccessor(0), accessor, quantAccessor, stats);

var mztabm_filename = alignmentFile.FileName + ".mzTabM";
var mztabm_filename = alignmentFile.FileName + ".mzTab";
Copy link

Copilot AI Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable name 'mztabm_filename' still contains 'mztabm' but now stores a filename with '.mzTab' extension. Consider renaming this variable to 'mztab_filename' to better reflect its content and maintain consistency with the new extension naming convention.

Copilot uses AI. Check for mistakes.
align_mspexporter.BatchExport(streammsp, result.AlignmentSpotProperties, align_decResults);

var mztabm_filename = alignmentFile.FileName + ".mzTabM";
var mztabm_filename = alignmentFile.FileName + ".mzTab";
Copy link

Copilot AI Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable name 'mztabm_filename' still contains 'mztabm' but now stores a filename with '.mzTab' extension. Consider renaming this variable to 'mztab_filename' to better reflect its content and maintain consistency with the new extension naming convention.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants