Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an alignment directory issue by changing how the alignment file path is determined. Instead of passing the input parameter directly to GetAlignmentFileBean, it now extracts the directory path from the first analysis file and validates both the analysis files collection and directory existence.
Key changes:
- Added validation to check if analysis files list is empty before processing
- Added directory existence check for the alignment folder
- Changed alignment file parsing to use the directory from the first analysis file instead of the input parameter
Comments suppressed due to low confidence (1)
tests/MSDIAL5/MsdialCoreTestApp/Process/CommonProcess.cs:42
- The check for whether analysisFiles is empty or null is performed twice - once at lines 27-31 and again at lines 39-42. Since the first check already returns false when analysisFiles is empty or null, the second check at line 39 is unreachable and should be removed.
if (analysisFiles.IsEmptyOrNull()) {
Console.WriteLine(CommonProcess.NoFileError());
return false;
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Bujee415
approved these changes
Dec 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.