Skip to content

fixed alignment directory issue#681

Merged
Bujee415 merged 2 commits intomasterfrom
fixed_v5console
Dec 11, 2025
Merged

fixed alignment directory issue#681
Bujee415 merged 2 commits intomasterfrom
fixed_v5console

Conversation

@htsugawa
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes an alignment directory issue by changing how the alignment file path is determined. Instead of passing the input parameter directly to GetAlignmentFileBean, it now extracts the directory path from the first analysis file and validates both the analysis files collection and directory existence.

Key changes:

  • Added validation to check if analysis files list is empty before processing
  • Added directory existence check for the alignment folder
  • Changed alignment file parsing to use the directory from the first analysis file instead of the input parameter
Comments suppressed due to low confidence (1)

tests/MSDIAL5/MsdialCoreTestApp/Process/CommonProcess.cs:42

  • The check for whether analysisFiles is empty or null is performed twice - once at lines 27-31 and again at lines 39-42. Since the first check already returns false when analysisFiles is empty or null, the second check at line 39 is unreachable and should be removed.
            if (analysisFiles.IsEmptyOrNull()) {
                Console.WriteLine(CommonProcess.NoFileError());
                return false;
            }

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@Bujee415 Bujee415 merged commit daa4bd0 into master Dec 11, 2025
9 checks passed
@Bujee415 Bujee415 deleted the fixed_v5console branch December 11, 2025 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants