Add Hive file type support to FileTypeChecker#678
Merged
Conversation
Added a new `ContainsHive` property to track Hive file types. Enhanced `CheckFileType` to detect `.hmd` and `.mzb` extensions and updated `ClearFileTypeInfo` to reset `ContainsHive`. Modified `GetSupportMessage` to include a notice about Hive file format support, warning users about potential future unavailability and suggesting updates to newer MS-DIAL versions.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for detecting Hive file formats (.hmd and .mzb extensions) in the MS-DIAL application's file type checker system, with an accompanying user notice about potential future unavailability of Hive format support.
- Added
ContainsHiveproperty to track presence of Hive file types - Enhanced file type detection to recognize
.hmdand.mzbextensions - Added user-facing notification about Hive format support lifecycle
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| builder.AppendLine(); | ||
| } | ||
| builder.AppendLine("Hive Format Notice"); | ||
| builder.AppendLine("The Hive data reader may become unavailable after the support period ends. If you are unable to read Hive data, please consider using a newer version of MS-DIAL."); |
There was a problem hiding this comment.
The message says "may become unavailable after the support period ends" but doesn't specify when that support period is or provide any concrete timeline. This makes the warning vague and unhelpful for users trying to plan their usage. Consider either:
- Specifying the actual support end date if known (e.g., "after [DATE]")
- Providing a version number where support will end
- Making the message more actionable without the vague timeline reference
Suggested change
| builder.AppendLine("The Hive data reader may become unavailable after the support period ends. If you are unable to read Hive data, please consider using a newer version of MS-DIAL."); | |
| builder.AppendLine("Support for the Hive data reader is planned to end after June 30, 2024. If you are unable to read Hive data after this date, please consider using a newer version of MS-DIAL or consult the official MS-DIAL website for the latest support information."); |
Bujee415
approved these changes
Dec 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Hive file type support to FileTypeChecker
Added a new
ContainsHiveproperty to track Hive file types.Enhanced
CheckFileTypeto detect.hmdand.mzbextensionsand updated
ClearFileTypeInfoto resetContainsHive.Modified
GetSupportMessageto include a notice about Hivefile format support, warning users about potential future
unavailability and suggesting updates to newer MS-DIAL versions.