Merged
Conversation
# Conflicts: # src/MSDIAL5/MsdialCore/Export/AlignmentGnpsExporter.cs # src/MSDIAL5/MsdialGuiApp/Model/Export/AlignmentGnpsExportModel.cs
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the GNPS export pipeline to fix metadata and MGF output issues.
- Replace AccessPeakMetaModel with a dedicated GnpsMetadataAccessor implementing IMetadataAccessor.
- Modify MGF export to use MSDec spectra and optionally omit the "Num Peaks" line.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/MSDIAL5/MsdialGuiApp/Model/Lcms/LcmsMethodModel.cs | Switch GNPS export to use GnpsMetadataAccessor. |
| src/MSDIAL5/MsdialGuiApp/Model/Lcimms/LcimmsMethodModel.cs | Switch GNPS export to use GnpsMetadataAccessor. |
| src/MSDIAL5/MsdialGuiApp/Model/Imms/ImmsMethodModel.cs | Switch GNPS export to use GnpsMetadataAccessor. |
| src/MSDIAL5/MsdialGuiApp/Model/Gcms/GcmsMethodModel.cs | Switch GNPS export to use GnpsMetadataAccessor. |
| src/MSDIAL5/MsdialGuiApp/Model/Export/AlignmentGnpsExportModel.cs | Update model to accept IMetadataAccessor and pass msdecResults to MGF export. |
| src/MSDIAL5/MsdialCore/Export/SpectraExport.cs | Add optional flag to omit "Num Peaks" line in MGF and plumb it through. |
| src/MSDIAL5/MsdialCore/Export/GnpsMetadataAccessor.cs | New accessor providing GNPS-specific headers and content. |
| src/MSDIAL5/MsdialCore/Export/AlignmentGnpsExporter.cs | Update GNPS MGF export to use MSDec spectra and omit "Num Peaks". |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.