Implement analysis pipeline and UI for TIMS-off imaging#639
Merged
Implement analysis pipeline and UI for TIMS-off imaging#639
Conversation
Move SaveImagesViewModel from ImagingImms to Imaging directory
Update ImagingDims.ImagingMainView
Introduced a new `DataTemplate` for the `ImagingDimsMainViewModel`, including necessary XML namespace declarations and an `ImagingMainView` element. The existing `DataTemplate` for `ImagingImmsMainViewModel` remains unchanged.
Modified the MsdialDimsParameter constructor to include an isImaging parameter, allowing for dynamic selection of MachineCategory. Updated the CreateParameter method in DatasetParameterSettingModel.cs to instantiate MsdialDimsParameter with the appropriate isImaging value based on the separation type.
Introduce a new class `ImagingDimsMethodSettingModelFactory` to handle method settings for imaging dimensions (IDIMS). Update `MethodSettingModelFactory` to conditionally use this new factory based on the `MachineCategory` of `dimsStorage`. The new factory includes methods for creating various settings models tailored for imaging dimensions.
Modified the "Imaging" CheckBox to bind the `IsEnabled` property to `DirectInfution.Value`. Removed the previous `MultiBinding` for `IsEnabled` and updated the style by eliminating a `DataTrigger` that set `IsChecked` to `False` based on `SeparationIonMobility.Value`.
Introduced a new `DataTemplate` for `LipidmapsLinkViewModel` in `ImagingMainView.xaml`. This includes a `TextBlock` with the text "Links", a tooltip for database links, and a vertical alignment set to stretch. An `info:LipidmapsLinkView` control was also added to the template.
Updated binding syntax in DataCollectionSettingView.xaml to use explicit `Path` format for improved readability and maintainability. Adjusted properties of `TextBox`, `ContentControl`, and `StackPanel` to ensure uniformity across the file without altering functionality.
Updated the `SaveAsync` method in `IntensityImageModel` to accept `skipUnknownPeaks` and `token` parameters, improving its functionality and cancellation support. Adjusted calls to `SaveAsync` in `WholeImageResultModel` to utilize the new parameters, ensuring consistent behavior across the codebase.
Bujee415
approved these changes
Sep 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Classification
New feature implementation for imaging data management and processing.
PR Summary
This pull request introduces new classes and interfaces to enhance imaging data handling, including the addition of methods for managing regions of interest (ROIs) and updating existing models to support new imaging functionalities.
DimsProviderFactoryParameter.cs: Introduced new methods inIDimsDataProviderFactoryParameterfor creatingRawMeasurementdata providers.ImagingDimsImageModel.cs: New class created to manage imaging data and ROIs.WholeImageResultModel.cs: Updated to implementIWholeImageResultModeland manage intensity images.