Skip to content

Implement analysis pipeline and UI for TIMS-off imaging#639

Merged
Bujee415 merged 23 commits intomasterfrom
feature/dims-imaging
Sep 30, 2025
Merged

Implement analysis pipeline and UI for TIMS-off imaging#639
Bujee415 merged 23 commits intomasterfrom
feature/dims-imaging

Conversation

@YukiMatsuzawa
Copy link
Copy Markdown
Contributor

PR Classification

New feature implementation for imaging data management and processing.

PR Summary

This pull request introduces new classes and interfaces to enhance imaging data handling, including the addition of methods for managing regions of interest (ROIs) and updating existing models to support new imaging functionalities.

  • DimsProviderFactoryParameter.cs: Introduced new methods in IDimsDataProviderFactoryParameter for creating RawMeasurement data providers.
  • ImagingDimsImageModel.cs: New class created to manage imaging data and ROIs.
  • WholeImageResultModel.cs: Updated to implement IWholeImageResultModel and manage intensity images.
  • XAML files: Updated to include new UI elements for imaging functionalities, enhancing user interaction.

Move SaveImagesViewModel from ImagingImms to Imaging directory
Update ImagingDims.ImagingMainView
Introduced a new `DataTemplate` for the `ImagingDimsMainViewModel`, including necessary XML namespace declarations and an `ImagingMainView` element. The existing `DataTemplate` for `ImagingImmsMainViewModel` remains unchanged.
Modified the MsdialDimsParameter constructor to include an
isImaging parameter, allowing for dynamic selection of
MachineCategory. Updated the CreateParameter method in
DatasetParameterSettingModel.cs to instantiate
MsdialDimsParameter with the appropriate isImaging value
based on the separation type.
Introduce a new class `ImagingDimsMethodSettingModelFactory` to handle method settings for imaging dimensions (IDIMS). Update `MethodSettingModelFactory` to conditionally use this new factory based on the `MachineCategory` of `dimsStorage`. The new factory includes methods for creating various settings models tailored for imaging dimensions.
Modified the "Imaging" CheckBox to bind the `IsEnabled` property to `DirectInfution.Value`. Removed the previous `MultiBinding` for `IsEnabled` and updated the style by eliminating a `DataTrigger` that set `IsChecked` to `False` based on `SeparationIonMobility.Value`.
Introduced a new `DataTemplate` for `LipidmapsLinkViewModel` in `ImagingMainView.xaml`. This includes a `TextBlock` with the text "Links", a tooltip for database links, and a vertical alignment set to stretch. An `info:LipidmapsLinkView` control was also added to the template.
Updated binding syntax in DataCollectionSettingView.xaml
to use explicit `Path` format for improved readability
and maintainability. Adjusted properties of `TextBox`,
`ContentControl`, and `StackPanel` to ensure uniformity
across the file without altering functionality.
Updated the `SaveAsync` method in `IntensityImageModel` to accept `skipUnknownPeaks` and `token` parameters, improving its functionality and cancellation support. Adjusted calls to `SaveAsync` in `WholeImageResultModel` to utilize the new parameters, ensuring consistent behavior across the codebase.
@Bujee415 Bujee415 merged commit 7ce5b5d into master Sep 30, 2025
5 checks passed
@Bujee415 Bujee415 deleted the feature/dims-imaging branch September 30, 2025 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants