Skip to content

Fix gcms dataprocessing bug#638

Merged
YukiMatsuzawa merged 30 commits intomasterfrom
fix_gcms_dataprocessing_bug
Oct 1, 2025
Merged

Fix gcms dataprocessing bug#638
YukiMatsuzawa merged 30 commits intomasterfrom
fix_gcms_dataprocessing_bug

Conversation

@htsugawa
Copy link
Copy Markdown
Contributor

No description provided.

YukiMatsuzawa and others added 25 commits August 18, 2025 13:46
Move SaveImagesViewModel from ImagingImms to Imaging directory
Update ImagingDims.ImagingMainView
Introduced a new `DataTemplate` for the `ImagingDimsMainViewModel`, including necessary XML namespace declarations and an `ImagingMainView` element. The existing `DataTemplate` for `ImagingImmsMainViewModel` remains unchanged.
Modified the MsdialDimsParameter constructor to include an
isImaging parameter, allowing for dynamic selection of
MachineCategory. Updated the CreateParameter method in
DatasetParameterSettingModel.cs to instantiate
MsdialDimsParameter with the appropriate isImaging value
based on the separation type.
Introduce a new class `ImagingDimsMethodSettingModelFactory` to handle method settings for imaging dimensions (IDIMS). Update `MethodSettingModelFactory` to conditionally use this new factory based on the `MachineCategory` of `dimsStorage`. The new factory includes methods for creating various settings models tailored for imaging dimensions.
Modified the "Imaging" CheckBox to bind the `IsEnabled` property to `DirectInfution.Value`. Removed the previous `MultiBinding` for `IsEnabled` and updated the style by eliminating a `DataTrigger` that set `IsChecked` to `False` based on `SeparationIonMobility.Value`.
Introduced a new `DataTemplate` for `LipidmapsLinkViewModel` in `ImagingMainView.xaml`. This includes a `TextBlock` with the text "Links", a tooltip for database links, and a vertical alignment set to stretch. An `info:LipidmapsLinkView` control was also added to the template.
Updated binding syntax in DataCollectionSettingView.xaml
to use explicit `Path` format for improved readability
and maintainability. Adjusted properties of `TextBox`,
`ContentControl`, and `StackPanel` to ensure uniformity
across the file without altering functionality.
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements a new "gcms dataprocessing bug fix" that introduces support for imaging DIMS (Direct Infusion Mass Spectrometry) functionality alongside the existing imaging IMMS capabilities. The key changes include adding a new ImagingDims module with corresponding ViewModels, Views, and data models to handle DIMS-specific imaging processing.

Key changes:

  • Adds imaging DIMS support with new ViewModels, Views, and Models
  • Refactors common imaging functionality into shared interfaces and base classes
  • Updates parameter settings to support imaging DIMS configuration
  • Removes debug console output from IMMS file processing

Reviewed Changes

Copilot reviewed 33 out of 33 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
MsdialImmsImagingCore/Process/FileProcess.cs Removes debug console output code
Multiple ViewModel files Updates collection initialization syntax and removes unused variables
Multiple View files Adds new imaging DIMS UI components and updates XAML bindings
Multiple Model files Implements imaging DIMS data models and refactors shared interfaces
Setting files Updates parameter configuration to support imaging DIMS
Core algorithm files Adds new DIMS data provider factories and parameter handling

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@YukiMatsuzawa YukiMatsuzawa merged commit 9368cb2 into master Oct 1, 2025
5 checks passed
@YukiMatsuzawa YukiMatsuzawa deleted the fix_gcms_dataprocessing_bug branch October 1, 2025 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants