Merged
Conversation
Move SaveImagesViewModel from ImagingImms to Imaging directory
Update ImagingDims.ImagingMainView
Introduced a new `DataTemplate` for the `ImagingDimsMainViewModel`, including necessary XML namespace declarations and an `ImagingMainView` element. The existing `DataTemplate` for `ImagingImmsMainViewModel` remains unchanged.
Modified the MsdialDimsParameter constructor to include an isImaging parameter, allowing for dynamic selection of MachineCategory. Updated the CreateParameter method in DatasetParameterSettingModel.cs to instantiate MsdialDimsParameter with the appropriate isImaging value based on the separation type.
Introduce a new class `ImagingDimsMethodSettingModelFactory` to handle method settings for imaging dimensions (IDIMS). Update `MethodSettingModelFactory` to conditionally use this new factory based on the `MachineCategory` of `dimsStorage`. The new factory includes methods for creating various settings models tailored for imaging dimensions.
Modified the "Imaging" CheckBox to bind the `IsEnabled` property to `DirectInfution.Value`. Removed the previous `MultiBinding` for `IsEnabled` and updated the style by eliminating a `DataTrigger` that set `IsChecked` to `False` based on `SeparationIonMobility.Value`.
Introduced a new `DataTemplate` for `LipidmapsLinkViewModel` in `ImagingMainView.xaml`. This includes a `TextBlock` with the text "Links", a tooltip for database links, and a vertical alignment set to stretch. An `info:LipidmapsLinkView` control was also added to the template.
Updated binding syntax in DataCollectionSettingView.xaml to use explicit `Path` format for improved readability and maintainability. Adjusted properties of `TextBox`, `ContentControl`, and `StackPanel` to ensure uniformity across the file without altering functionality.
…umulation in DIMS
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements a new "gcms dataprocessing bug fix" that introduces support for imaging DIMS (Direct Infusion Mass Spectrometry) functionality alongside the existing imaging IMMS capabilities. The key changes include adding a new ImagingDims module with corresponding ViewModels, Views, and data models to handle DIMS-specific imaging processing.
Key changes:
- Adds imaging DIMS support with new ViewModels, Views, and Models
- Refactors common imaging functionality into shared interfaces and base classes
- Updates parameter settings to support imaging DIMS configuration
- Removes debug console output from IMMS file processing
Reviewed Changes
Copilot reviewed 33 out of 33 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| MsdialImmsImagingCore/Process/FileProcess.cs | Removes debug console output code |
| Multiple ViewModel files | Updates collection initialization syntax and removes unused variables |
| Multiple View files | Adds new imaging DIMS UI components and updates XAML bindings |
| Multiple Model files | Implements imaging DIMS data models and refactors shared interfaces |
| Setting files | Updates parameter configuration to support imaging DIMS |
| Core algorithm files | Adds new DIMS data provider factories and parameter handling |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Bujee415
approved these changes
Sep 30, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
YukiMatsuzawa
approved these changes
Sep 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.