Fixed Error During Peak Switching by Adjusting Graph Axis Update Order#620
Merged
Fixed Error During Peak Switching by Adjusting Graph Axis Update Order#620
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an error during peak switching by modifying the order in which graph axis updates are performed. The change addresses a timing issue that was causing errors when switching between peaks in the spectra similarity map.
- Replaces direct collection clearing and population with local collection building
- Ensures atomic updates to the OrderedFiles property to prevent intermediate states
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
+186
to
+192
| var files = new List<AnalysisFileBeanModel>(matrix.GetLength(0)); | ||
| tree.NodePreOrder(i => { | ||
| if (tree[i].Count() == 0) { | ||
| OrderedFiles.Add(Files.AnalysisFiles[i]); | ||
| files.Add(Files.AnalysisFiles[i]); | ||
| } | ||
| }); | ||
| OrderedFiles = files; |
There was a problem hiding this comment.
The same code pattern is duplicated in both UpdateSimilaritiesAsync methods. Consider extracting this logic into a private method like 'BuildOrderedFilesFromTree(matrix, tree)' to reduce code duplication and improve maintainability.
Bujee415
approved these changes
Aug 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.