Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes a bug in EAD lipidomics projects where the EAD annotation process failed to execute during initial analysis by standardizing the DataBaseMapper initialization pattern across all analysis workflows.
- Replaces the
CreateDataBaseMapper()method calls with explicitDataBaseMapperinstantiation and assignment - Ensures consistent mapper initialization by creating the mapper instance before setting it on the database storage
- Removes the
CreateDataBaseMapper()method fromDataBaseStorageclass to prevent inconsistent usage patterns
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| MaldiMsProcessTest.cs | Updates test methods to use explicit DataBaseMapper instantiation and parameter passing |
| LcmsProcess.cs | Standardizes DataBaseMapper initialization pattern in LCMS workflow |
| LcimmsProcess.cs | Standardizes DataBaseMapper initialization pattern in LC-IMMS workflow |
| ImmsProcess.cs | Standardizes DataBaseMapper initialization pattern in IMMS workflow |
| GcmsProcess.cs | Standardizes DataBaseMapper initialization pattern in GCMS workflow |
| DimsProcess.cs | Standardizes DataBaseMapper initialization pattern in DIMS workflow |
| MethodSettingModel.cs | Updates GUI model to use SetDataBaseMapper instead of CreateDataBaseMapper |
| GcmsAlignmentProcessFactory.cs | Uses container's DataBaseMapper instead of creating new one |
| DataBaseStorage.cs | Removes the CreateDataBaseMapper method to enforce consistent initialization |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Bujee415
approved these changes
Aug 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes a bug specific to EAD lipidomics projects where the EAD annotation process failed to execute during the initial analysis.