Merged
Conversation
Modified tooltip content for clarity and added a new Viewbox with a TextBlock to guide users on file selection via 'Browse' or drag-and-drop. The TextBlock visibility is conditional based on the file selection count. Additionally, a read-only TextBox was introduced to display supporting messages.
Bujee415
approved these changes
Jun 18, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the user interface by updating tooltip text and adding a new UI element that displays a file selection instruction when no files are present.
- Updated tooltip content in DatasetFileSettingView.xaml to remove outdated format information.
- Added a Viewbox with a TextBlock to prompt users to select files or drag and drop when no files are available.
Comments suppressed due to low confidence (1)
src/MSDIAL5/MsdialGuiApp/View/Setting/DatasetFileSettingView.xaml:258
- [nitpick] Consider externalizing this user instruction text to a resource file for easier localization and future maintenance.
Click 'Browse' to select files or drag and drop here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Classification
Enhancement of user interface elements and feedback mechanisms.
PR Summary
This pull request updates the tooltip for a button and introduces new UI elements to improve user interaction.
Viewboxwith aTextBlockthat prompts users to select files or drag and drop when no files are present.