Conversation
Changed `ExecuteChromDeconvolution` and `ExecuteQ1Deconvolution` from read-only to read-write properties, allowing modification after initialization. Default values remain unchanged. # Conflicts: # src/MSDIAL5/MsdialCore/Parameter/ParameterBase.cs
Updated `DeconvolutionSettingModel.cs` to include new boolean properties `ExecuteChromDeconvolution` and `ExecuteQ1Deconvolution`, allowing users to control chromatogram-based and Q1 axis peak deconvolution. Modified the `Commit` method to save these settings. Enhanced `DeconvolutionSettingView.xaml` with checkboxes for the new settings, including tooltips for user guidance. Synchronized the new properties in `DeconvolutionSettingViewModel.cs` to ensure UI changes reflect in the model, maintaining validation consistency.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new boolean property, ExecuteChromDeconvolution, to enable or disable chromatogram-based deconvolution. Key changes include:
- Adding the property to ParameterBase with a default value of true
- Integrating the property in the model and view model with reactive binding
- Updating the UI by introducing a checkbox to control the deconvolution execution
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/MSDIAL5/MsdialGuiApp/ViewModel/Setting/DeconvolutionSettingViewModel.cs | Added reactive binding for ExecuteChromDeconvolution |
| src/MSDIAL5/MsdialGuiApp/View/Setting/DeconvolutionSettingView.xaml | Introduced a checkbox for ExecuteChromDeconvolution (label text may cause confusion) |
| src/MSDIAL5/MsdialGuiApp/Model/Setting/DeconvolutionSettingModel.cs | Integrated ExecuteChromDeconvolution in Commit and LoadParameter methods |
| src/MSDIAL5/MsdialCore/Parameter/ParameterBase.cs | Added ExecuteChromDeconvolution with a default value to the parameter definition |
Comments suppressed due to low confidence (1)
src/MSDIAL5/MsdialGuiApp/View/Setting/DeconvolutionSettingView.xaml:85
- The label 'Run RT deconvolution:' may be misleading given that the new property ExecuteChromDeconvolution controls chromatogram-based deconvolution. Consider updating the label to more clearly reflect the intended feature, such as 'Execute Chromatogram Deconvolution:'.
<ui:LabeledContent PrependLabel="Run RT deconvolution:"
Bujee415
approved these changes
Jun 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Classification
New feature to enhance chromatogram deconvolution functionality.
PR Summary
This pull request introduces a new boolean property
ExecuteChromDeconvolutionto control the execution of chromatogram-based deconvolution. It includes updates to the model, view model, and UI to support this feature.ParameterBase.cs: AddedExecuteChromDeconvolutionproperty with a default value oftrue.DeconvolutionSettingModel.cs: IntegratedExecuteChromDeconvolutioninto the model and updated theCommitmethod to save its state.DeconvolutionSettingView.xaml: Added a checkbox in the UI for users to enable or disableExecuteChromDeconvolution.DeconvolutionSettingViewModel.cs: Created a reactive property forExecuteChromDeconvolutionto synchronize with the model and included it in error observation logic.