Conversation
…ject loading. When a project is moved to a new folder, the loading logic now prioritizes searching for files in the new folder location over the original folder. This ensures better handling of relocated projects and avoids unnecessary fallback to the original folder.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves project loading by prioritizing file searches in the new folder location when a project is moved.
- The first try block now attempts to load using newProjectDir with additional folder fixes and retention of previous RT correction results.
- The fallback logic has been updated to load from projectDir if needed.
Comments suppressed due to low confidence (1)
src/MSDIAL5/MsdialCore/DataObj/ProjectDataStorage.cs:143
- Consider adding logging or more specific exception handling in this catch block to aid debugging while still allowing the fallback logic to proceed.
catch {
Bujee415
approved these changes
Jun 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prioritized searching for files in the new folder location during project loading.
When a project is moved to a new folder, the loading logic now prioritizes searching for files in the new folder location over the original folder. This ensures better handling of relocated projects and avoids unnecessary fallback to the original folder.