Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the MS-FINDER version notification and about window to reflect the new version and contributor details.
- Refactors the version comparison logic in VersionUpdateNotificationService.cs using a regex-based extraction
- Updates resource values (date and version) in Resources.resx
- Adjusts layout and contributor information in HelpAboutWindow.xaml
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/MSFINDER/MSFINDER/Version update/VersionUpdateNotificationService.cs | Refactored version extraction and popup display logic using regex |
| src/MSFINDER/MSFINDER/Properties/Resources.resx | Updated version string and date values |
| src/MSFINDER/MSFINDER/Help/HelpAboutWindow.xaml | Modified window sizing and updated contributor/contact details |
| { | ||
| if (Rfx.Riken.OsakaUniv.Properties.Resources.VERSION != vdd.LatestVersion) { | ||
| // TODO Show version update information in a popup | ||
| var currentVersionString = Rfx.Riken.OsakaUniv.Properties.Resources.VERSION; |
There was a problem hiding this comment.
Consider using .NET's Version.TryParse and comparing Version objects instead of string equality for more robust version comparisons.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.