Conversation
There was a problem hiding this comment.
Pull Request Overview
Replace the embedded Notame PNG with a new vector-based icon and hook it into the ribbon control.
- Switch
Notamebutton’sLargeImageSourcefrom the PNG path to the newStaticResource Notame_is - Define a scalable
Viewboxvector forNotameand a correspondingDrawingImageresource - Ensure the icon is available as a StaticResource for UI rendering
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| MsdialDataVisualizationTab.xaml | Updated the Notame ribbon button to use the new vector resource key Notame_is |
| Icons.xaml | Added <Viewbox x:Key="Notame"> and <DrawingImage x:Key="Notame_is"> entries defining the vector logo |
Comments suppressed due to low confidence (1)
src/MSDIAL5/MsdialGuiApp/View/RibbonControl/MsdialDataVisualizationTab.xaml:49
- Verify that
Notame_isis merged into the same ResourceDictionary before this control loads, otherwise the StaticResource lookup will fail at runtime. You may need to add the Icons.xaml merge to App.xaml or the control’s local dictionaries.
<RibbonButton Label="Notame (two-parameter processing tool)" LargeImageSource="{StaticResource Notame_is}"
| <DrawingImage.Drawing> | ||
| <GeometryDrawing> | ||
| <GeometryDrawing.Geometry> | ||
| <RectangleGeometry Rect="0,0,255,255"/> |
There was a problem hiding this comment.
The RectangleGeometry Rect="0,0,255,255" does not match the Viewbox’s 210×297 canvas dimensions, which may lead to clipping or improper scaling. Consider using a matching Rect (e.g., 0,0,210,297) or adjusting the VisualBrush alignment.
| <RectangleGeometry Rect="0,0,255,255"/> | |
| <RectangleGeometry Rect="0,0,210,297"/> |
| <PathGeometry x:Key="clipEmfPath1" Figures="M 52.781102 60.188976 L 118.52598 60.188976 L 118.52598 125.93386 L 52.781102 125.93386 z" FillRule="NonZero"/> | ||
| <PathGeometry x:Key="clipEmfPath1-6" Figures="M 81.486614 87.968504 L 147.2315 87.968504 L 147.2315 144.45354 L 81.486614 144.45354 z" FillRule="NonZero"/> | ||
| </Canvas.Resources> | ||
| <Canvas UseLayoutRounding="False" Width="66.122391" Height="74.950409"> |
There was a problem hiding this comment.
[nitpick] There’s a deep hierarchy of nested Canvas elements with individual RenderTransform settings, which makes the XAML harder to maintain. Consider flattening transforms or using a single DrawingGroup to simplify the vector definition.
No description provided.