Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces internal updates for the MS-FINDER integration and various refactorings and renamings to improve the codebase’s consistency. Key changes include:
- Adding a temporary ShortMessageWindow popup in multiple view models during MS-FINDER command execution.
- Refactoring of InternalMsFinderSingleSpot to use view model types and updating method calls to use new file storage utilities.
- Renaming and updating of various methods and properties in the common libraries (e.g. FragmentAssigner and FormulaResult) for consistency.
Reviewed Changes
Copilot reviewed 22 out of 24 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/MSDIAL5/MsdialGuiApp/ViewModel/* | Introduces ShortMessageWindow popups in several view models for background notifications. |
| src/MSDIAL5/MsdialGuiApp/Model/Search/InternalMsFinderSingleSpot.cs | Updates to use view-model types and simplifies message popup behavior. |
| src/Common/CommonStandard/Utility/FileStorageUtility.cs | Updates AdductIon API usage. |
| src/Common/CommonStandard/StructureFinder/* | Renames methods (e.g. GetDabaseQueries) and updates adduct ion retrieval calls. |
| src/Common/CommonStandard/StructureFinder/Result/FragmenterResult.cs | Adds a new property (FragmenterScore) with initialization. |
| src/Common/CommonStandard/FormulaGenerator/* | Fixes method naming for fragment assigners and uses the new List initializer syntax. |
| src/Common/CommonStandard/Components/SpectrumPeak.cs | Adds a new property for FragmentationScore. |
Files not reviewed (2)
- src/MSDIAL5/MsdialGuiApp/View/Search/InternalMsFinderSingleSpotView.xaml: Language not supported
- src/MSDIAL5/MsdialGuiApp/View/Setting/InternalMsfinderSettingView.xaml: Language not supported
Comments suppressed due to low confidence (1)
src/Common/CommonStandard/StructureFinder/MainProcess.cs:63
- [nitpick] The method name 'GetDabaseQueries' contains a misspelling. It may be clearer to rename it to 'GetDatabaseQueries' for better readability.
var dbQueries = GetDabaseQueries(param.DatabaseQuery);
…odel.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.