libsystemd: device_has_info: return true for usec_initialized#6551
Closed
sfanxiang wants to merge 1 commit intosystemd:masterfrom
Closed
libsystemd: device_has_info: return true for usec_initialized#6551sfanxiang wants to merge 1 commit intosystemd:masterfrom
sfanxiang wants to merge 1 commit intosystemd:masterfrom
Conversation
Without this patch, device_update_db() will not create the database file for an initialized device, which makes device_read_db() fail, and sd_device_get_is_initialized() will say that the device is not initialized.
Member
|
@teg @kaysievers please say something |
Contributor
|
device_has_info() means "will this device need to write a database?", usec_initialized does not belong into this check. Can you please explain what exactly goes wrong here? It is (so far at least) expected behavior, that devices which do not store anything defined by rules, will skip a database entry and not return "initialized". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this patch, device_update_db() will not create the database
file for an initialized device, which makes device_read_db() fail, and
sd_device_get_is_initialized() will say that the device is not
initialized.