Skip to content

Meson: Mute meson build warning for geneve HAVE_DECL_IFLA_GENEVE_LABEL#5804

Merged
mbiebl merged 1 commit intosystemd:masterfrom
ssahani:geneve
Apr 25, 2017
Merged

Meson: Mute meson build warning for geneve HAVE_DECL_IFLA_GENEVE_LABEL#5804
mbiebl merged 1 commit intosystemd:masterfrom
ssahani:geneve

Conversation

@ssahani
Copy link
Copy Markdown
Contributor

@ssahani ssahani commented Apr 25, 2017

  ^~~~~~~~~~~~~~~~~~~~~~~~~~~

[107/1793] Compiling c object 'src/basic/basic@sta/log.c.o'
In file included from ../src/basic/log.c:44:0:
../src/basic/missing.h:762:6: warning: "HAVE_DECL_IFLA_GENEVE_LABEL" is not defined, evaluates to 0 [-Wundef]
#if !HAVE_DECL_IFLA_GENEVE_LABEL
^~~~~~~~~~~~~~~~~~~~~~~~~~~
[108/1793] Compiling c object 'src/basic/basic@sta/path-util.c.o'
In file included from ../src/basic/path-util.c:40:0:
../src/basic/missing.h:762:6: warning: "HAVE_DECL_IFLA_GENEVE_LABEL" is not defined, evaluates to 0 [-Wundef]
#if !HAVE_DECL_IFLA_GENEVE_LABEL
^~~~~~~~~~~~~~~~~~~~~~~~~~~

Copy link
Copy Markdown
Contributor

@evverx evverx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

netdev/geneve.h and netdev/geneve.c should be built too.

@mbiebl
Copy link
Copy Markdown
Contributor

mbiebl commented Apr 25, 2017

I would prefix the commit messages touching the meson build system with "meson: ..."

```
[107/1793] Compiling c object 'src/basic/basic@sta/log.c.o'
In file included from ../src/basic/log.c:44:0:
../src/basic/missing.h:762:6: warning: "HAVE_DECL_IFLA_GENEVE_LABEL" is not defined, evaluates to 0 [-Wundef]
^~~~~~~~~~~~~~~~~~~~~~~~~~~
[108/1793] Compiling c object 'src/basic/basic@sta/path-util.c.o'
In file included from ../src/basic/path-util.c:40:0:
../src/basic/missing.h:762:6: warning: "HAVE_DECL_IFLA_GENEVE_LABEL" is not defined, evaluates to 0 [-Wundef]
^~~~~~~~~~~~~~~~~~~~~~~~~~~

```
@ssahani ssahani changed the title Mute meson build warning for geneve HAVE_DECL_IFLA_GENEVE_LABEL Meson: Mute meson build warning for geneve HAVE_DECL_IFLA_GENEVE_LABEL Apr 25, 2017
@ssahani
Copy link
Copy Markdown
Contributor Author

ssahani commented Apr 25, 2017

updated

@mbiebl mbiebl merged commit 8b72119 into systemd:master Apr 25, 2017
@ssahani ssahani deleted the geneve branch April 25, 2017 16:12
@evverx
Copy link
Copy Markdown
Contributor

evverx commented Apr 25, 2017

@ssahani , @mbiebl , thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants