Skip to content

rules: Limit the number of device units generated for serial ttys#33263

Merged
bluca merged 1 commit intosystemd:mainfrom
daandemeyer:udev
Jun 11, 2024
Merged

rules: Limit the number of device units generated for serial ttys#33263
bluca merged 1 commit intosystemd:mainfrom
daandemeyer:udev

Conversation

@daandemeyer
Copy link
Copy Markdown
Collaborator

@daandemeyer daandemeyer commented Jun 10, 2024

As per the suggestion in #33242.

This reduces the number of /dev/ttySXX device units generated in mkosi from 32 to 4.

@github-actions github-actions bot added the please-review PR is ready for (re-)review by a maintainer label Jun 10, 2024
@github-actions
Copy link
Copy Markdown

Important

An -rc1 tag has been created and a release is being prepared, so please note that PRs introducing new features and APIs will be held back until the new version has been released.

@poettering
Copy link
Copy Markdown
Member

looks good to me (assuming you actually tested this, i only came up with this rule "dry", i am not entirely sure it works like this, didn't test it myself)

As per the suggestion in systemd#33242.

This reduces the number of /dev/ttySXX device units generated in
mkosi from 32 to 4.
@daandemeyer
Copy link
Copy Markdown
Collaborator Author

looks good to me (assuming you actually tested this, i only came up with this rule "dry", i am not entirely sure it works like this, didn't test it myself)

Of course I did! The number of tty device units for serial devices is reduced from 32 to 4 with this change.

@poettering
Copy link
Copy Markdown
Member

excellent! perfect!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

udev rules: don't allocate device units for unconfigured 8250 serial ports

4 participants