Skip to content

machine id: Added cmdline argument to use VM behaviour on bare metal #32086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
YHNdnzj merged 1 commit into from
Jul 13, 2024
Merged

machine id: Added cmdline argument to use VM behaviour on bare metal #32086

YHNdnzj merged 1 commit into from
Jul 13, 2024

Conversation

@FML128
Copy link
Contributor

@FML128 FML128 commented Apr 3, 2024 •
edited by github-actions bot
Loading

Should fix #30707.

@FML128 FML128 marked this pull request as ready for review April 4, 2024 08:00
@FML128 FML128 force-pushed the machine_id_smbios branch from 2ed8971 to 96c73da Compare April 4, 2024 08:00
@github-actions github-actions bot added the please-review PR is ready for (re-)review by a maintainer label Apr 4, 2024
@FML128 FML128 force-pushed the machine_id_smbios branch from 96c73da to b8e8667 Compare April 4, 2024 16:16
@poettering
Copy link
Member

poettering commented Apr 4, 2024

Hmm, I think adding this would be OK. but I think we should overload the existing systemd.machine_id= setting for this. i.e. if systemd.machine_id=smbios would mean: read the uuid from smbios.

and similar.

We just need to make sure that whatever special strings we introduce here they are under no circumstances something one could mistake for a proper machine ID. i.e. contain at least one character outside the [0-9a-f-] charset, and maybe are not 32ch long...

@poettering
Copy link
Member

poettering commented Apr 4, 2024

actually, it should be called systemd.machine_id=firmware I guess. After all we already support both smbios and devicetree for this, hence a more generic name sounds better

poettering
poettering reviewed Apr 4, 2024
View reviewed changes
@poettering
Copy link
Member

poettering commented Apr 4, 2024

looks conceptually ok, but please don#t call this "the vm logic", see above, and please add this to the existing systemd.machine_id= param just as a new special case.

@poettering poettering added reviewed/needs-rework 🔨 PR has been reviewed and needs another round of reworks and removed please-review PR is ready for (re-)review by a maintainer labels Apr 4, 2024
@FML128
Copy link
Contributor Author

FML128 commented Apr 4, 2024

Sure, makes sense. I will change it to systemd.machine_id=firmware.

@FML128 FML128 force-pushed the machine_id_smbios branch from b8e8667 to 3a01c44 Compare April 4, 2024 16:58
@github-actions github-actions bot added please-review PR is ready for (re-)review by a maintainer and removed reviewed/needs-rework 🔨 PR has been reviewed and needs another round of reworks labels Apr 4, 2024
@FML128 FML128 force-pushed the machine_id_smbios branch from 3a01c44 to fe3fa3d Compare April 4, 2024 18:15
bluca
bluca reviewed Apr 4, 2024
View reviewed changes
bluca
bluca reviewed Apr 4, 2024
View reviewed changes
bluca
bluca reviewed Apr 4, 2024
View reviewed changes
@bluca bluca added reviewed/needs-rework 🔨 PR has been reviewed and needs another round of reworks and removed please-review PR is ready for (re-)review by a maintainer labels Apr 4, 2024
@FML128 FML128 force-pushed the machine_id_smbios branch from fe3fa3d to 3ca51e6 Compare April 4, 2024 22:25
@github-actions github-actions bot added please-review PR is ready for (re-)review by a maintainer and removed reviewed/needs-rework 🔨 PR has been reviewed and needs another round of reworks labels Apr 4, 2024
@FML128 FML128 force-pushed the machine_id_smbios branch 2 times, most recently from 9046946 to 54d1484 Compare April 5, 2024 07:11
@FML128 FML128 requested review from bluca and poettering April 5, 2024 07:11
poettering
poettering reviewed Apr 17, 2024
View reviewed changes
poettering
poettering reviewed Jul 9, 2024
View reviewed changes
@poettering poettering added reviewed/needs-rework 🔨 PR has been reviewed and needs another round of reworks and removed please-review PR is ready for (re-)review by a maintainer labels Jul 9, 2024
@github-actions github-actions bot added please-review PR is ready for (re-)review by a maintainer and removed reviewed/needs-rework 🔨 PR has been reviewed and needs another round of reworks labels Jul 9, 2024
@FML128 FML128 force-pushed the machine_id_smbios branch 2 times, most recently from 56355da to 32a929b Compare July 9, 2024 11:56
@FML128 FML128 requested a review from poettering July 9, 2024 11:56
@FML128 FML128 force-pushed the machine_id_smbios branch from 32a929b to d63783e Compare July 9, 2024 11:57
@poettering
Copy link
Member

poettering commented Jul 9, 2024

Now I am happy! thank you!

@poettering poettering added good-to-merge/waiting-for-ci 👍 PR is good to merge, but CI hasn't passed at time of review. Please merge if you see CI has passed and removed please-review PR is ready for (re-)review by a maintainer labels Jul 9, 2024
YHNdnzj
YHNdnzj reviewed Jul 9, 2024
View reviewed changes
@FML128 FML128 force-pushed the machine_id_smbios branch from d63783e to f5c48db Compare July 9, 2024 13:27
@FML128 FML128 requested a review from YHNdnzj July 9, 2024 13:30
YHNdnzj
YHNdnzj reviewed Jul 9, 2024
View reviewed changes
@FML128 FML128 force-pushed the machine_id_smbios branch from f5c48db to 8692ede Compare July 9, 2024 13:34
@FML128 FML128 requested a review from YHNdnzj July 9, 2024 13:35
YHNdnzj
YHNdnzj approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@YHNdnzj YHNdnzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except for one problem

@YHNdnzj YHNdnzj added good-to-merge/with-minor-suggestions and removed good-to-merge/waiting-for-ci 👍 PR is good to merge, but CI hasn't passed at time of review. Please merge if you see CI has passed labels Jul 9, 2024
@FML128 FML128 force-pushed the machine_id_smbios branch from 8692ede to 37aaa32 Compare July 9, 2024 13:52
@FML128 FML128 requested a review from YHNdnzj July 9, 2024 13:53
@YHNdnzj YHNdnzj added good-to-merge/waiting-for-ci 👍 PR is good to merge, but CI hasn't passed at time of review. Please merge if you see CI has passed and removed good-to-merge/with-minor-suggestions labels Jul 9, 2024
@YHNdnzj YHNdnzj merged commit 274a38c into systemd:main Jul 13, 2024
@github-actions github-actions bot removed the good-to-merge/waiting-for-ci 👍 PR is good to merge, but CI hasn't passed at time of review. Please merge if you see CI has passed label Jul 13, 2024
@FML128 FML128 deleted the machine_id_smbios branch July 13, 2024 16:03
@arianvp arianvp mentioned this pull request Jun 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bluca bluca Awaiting requested review from bluca

@poettering poettering Awaiting requested review from poettering

@YHNdnzj YHNdnzj Awaiting requested review from YHNdnzj

Assignees

No one assigned

Labels

documentation util-lib

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Obtain machine-id from SMBIOS, DT, or TPM (on bare metal)

5 participants

@FML128 @poettering @septatrix @bluca @YHNdnzj