Skip to content

journalctl: fix --user when invoked by system users#27961

Merged
YHNdnzj merged 5 commits intosystemd:mainfrom
poettering:journalctl-user-unit-man-fix
Jun 8, 2023
Merged

journalctl: fix --user when invoked by system users#27961
YHNdnzj merged 5 commits intosystemd:mainfrom
poettering:journalctl-user-unit-man-fix

Conversation

@poettering
Copy link
Copy Markdown
Member

@poettering poettering commented Jun 7, 2023

Fixes: #26742
Fixes: #23679
Fixes: #25061

@github-actions github-actions bot added documentation meson util-lib please-review PR is ready for (re-)review by a maintainer labels Jun 7, 2023
@bluca bluca added good-to-merge/with-minor-suggestions and removed please-review PR is ready for (re-)review by a maintainer labels Jun 7, 2023
Let's move this helper call from journald specific code to src/basic/,
so that we can use it from sd-journal.

While we are at it, slightly extend it to also cover container uids,
which are also routed to the system journal now.

This places the call in uid-alloc-range.[ch] which contains similar
functions that match UID ranges for specific purposes.
@poettering poettering force-pushed the journalctl-user-unit-man-fix branch from b8030f7 to cad8fa4 Compare June 8, 2023 07:41
@poettering poettering added good-to-merge/waiting-for-ci 👍 PR is good to merge, but CI hasn't passed at time of review. Please merge if you see CI has passed and removed good-to-merge/with-minor-suggestions labels Jun 8, 2023
@poettering
Copy link
Copy Markdown
Member Author

made the one suggested fix and upgraded green label.

@YHNdnzj YHNdnzj merged commit 842248b into systemd:main Jun 8, 2023
@github-actions github-actions bot removed the good-to-merge/waiting-for-ci 👍 PR is good to merge, but CI hasn't passed at time of review. Please merge if you see CI has passed label Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

3 participants