Skip to content

Conversation

@yuwata
Copy link
Member

@yuwata yuwata commented Apr 28, 2023

@yuwata yuwata added the pid1 label Apr 28, 2023
@yuwata yuwata requested a review from poettering April 28, 2023 19:43
@github-actions github-actions bot added tests please-review PR is ready for (re-)review by a maintainer labels Apr 28, 2023
@bluca bluca added ci-fails/needs-rework 🔥 Please rework this, the CI noticed an issue with the PR and removed please-review PR is ready for (re-)review by a maintainer labels Apr 28, 2023
yuwata added 4 commits April 29, 2023 08:45
Otherwise,
1. X.path triggered X.service, and the service has waiting start job,
2. systemctl stop X.service
3. the waiting start job is cancelled to install new stop job,
4. path_trigger_notify() is called, and may reinstall new start job,
5. the stop job cannot be installed, and triggeres assertion.

So, instead, let's add a defer event source, then enqueue the new start
job after the stop (or any other type) job finished.

Fixes systemd#24577 (comment).
@yuwata yuwata force-pushed the core-path-trigger-notify branch from 0a9e5c9 to 843cb22 Compare April 29, 2023 00:10
@github-actions github-actions bot added please-review PR is ready for (re-)review by a maintainer and removed ci-fails/needs-rework 🔥 Please rework this, the CI noticed an issue with the PR labels Apr 29, 2023
@bluca bluca merged commit 708d63c into systemd:main Apr 29, 2023
@github-actions github-actions bot removed the please-review PR is ready for (re-)review by a maintainer label Apr 29, 2023
@yuwata yuwata deleted the core-path-trigger-notify branch April 29, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

init: Assertion 'hashmap_isempty(m->jobs)' failed at src/core/manager.c:1474, function manager_clear_jobs_and_units(). Aborting.

3 participants