-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
test: fixed negative checks in TEST-70-TPM2 #27079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
DaanDeMeyer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please write a proper commit message
Done sir. |
|
Please use a more descriptive commit message, it's too generic, check the git log for examples |
Alright sir. |
I'm looking at using this commit message: |
|
test: fix negative checks in TEST-70 Use in-line error handling rather than redirections. Follow-up for #27020 |
Wow.. Thank you so much sir. |
|
@DaanDeMeyer @bluca, commit message fixed sirs. |
|
It's not fixed, you've changed the PR description, but the git commit is still the same |
|
Yes, the ask is to use a better commit message, like the one I shared, so please amend it and push again |
I used this in the PR description.
This in the commit message
|
Sorry for making this drag for too long sir. right? |
|
You can see the commit message here: |
Make it match the PR title and description, with the title as the first line |
I have made the update sir. Thank you for the guidance. Is the current commit message good to fly? Does it yet need some fixes? |
|
almost - it's all in a single line, split it after the first period |
Awesome. |
Use in-line error handling rather than redirections. Follow up on systemd#27020
How about now sir? |
Follow-up for #27020