proc-cmdline: reimplement proc_cmdline_get_key_many_internal() #26963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No functional change, just refactoring.
keszybz
reviewed
Mar 28, 2023
Member
keszybz
left a comment
There was a problem hiding this comment.
Hmm, on their own, I'm not sure if those changes are useful. This version is much longer and it also seems harder to grok, with different layers. In the old version, things are much more straightforward.
|
|
||
| break; | ||
| if (value) { | ||
| r = free_and_strdup(&e->value, value); |
Member
There was a problem hiding this comment.
Hmm, I would expect us to replace e->value unconditionally. I.e. drop the if.
| r = free_and_strdup(&e->value, value); | ||
| if (r < 0) | ||
| return r; | ||
| } |
| typedef struct ProcCmdlineDataEntry { | ||
| const char *key; | ||
| char *value; | ||
| char **ret; |
Member
There was a problem hiding this comment.
What is ret? I think a more descriptive name would be better.
Member
Author
OK. I will take another way. Thank you for the comments. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No functional change, just refactoring.
Split-out of #26887.