network, core: revert NFTSet and NetLabel features#23774
Merged
yuwata merged 2 commits intosystemd:mainfrom Jun 22, 2022
Merged
network, core: revert NFTSet and NetLabel features#23774yuwata merged 2 commits intosystemd:mainfrom
yuwata merged 2 commits intosystemd:mainfrom
Conversation
fa3cfe1 to
bf0a503
Compare
Member
|
Is this ready for review? |
This reverts PR systemd#22587 and its follow-up commit. More specifically, 2299b1c (partially), e176f85, ceb46a3, and 51bb907. The PR was merged without final approval, and has several issues: - OSS fuzz reported issues in the conf parser, - It calls synchrnous netlink call, it should not be especially in PID1, - The importance of NFTSet for CGroup and DynamicUser may be questionable, at least, there was no justification PID1 should support it. - For networkd, it should be implemented with Request object, - There is no test for the feature. Fixes systemd#23711. Fixes systemd#23717. Fixes systemd#23719. Fixes systemd#23720. Fixes systemd#23721. Fixes systemd#23759.
This reverts PR systemd#23269 and its follow-up commit. Especially, 2299b1c (partially), and 3cf6383. The PR was merged without final approval, and has several issues: - The NetLabel for static addresses are not assigned, as labels are stored in the Address objects managed by Network, instead of Link. - If NetLabel is specified for a static address, then the address section will be invalid and the address will not be configured, - It should be implemented with Request object, - There is no test about the feature.
bf0a503 to
a32badc
Compare
Member
Author
|
@keszybz I've decided that, at least tentatively, we should revert both PRs. And I will open PR for cleaning up nfnl later. Hopefully, this should not conflict your PR. @topimiettinen Sorry for the decision, but please re-submit PRs about the features. Please read the commit messages what issues exist in the PRs. |
Member
|
Agreed. Let's merge this when tests pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately, NetLabel and NFTSet features are merged without final approval.
NFTSet feature has several major design issues.
Let's re-introduce these features carefully in later another PRs.
Fixes #23711.
Fixes #23717.
Fixes #23719.
Fixes #23720.
Fixes #23721.
Fixes #23759.
Closes #23676.