udevd: manager - don't unref event sources when event loop running #227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simply switch the sources off, but keep them around so the event loop can discard any unwanted events properly. Fixes issue systemd#163.
Contributor
|
set_enabled() has no effect after fork(). Your new code is a no-op. Can you explain what exactly goes wrong here? |
Contributor
|
Ok, scratch that... I thought this was manager_spawn()... sorry. Patch looks ok. I still don't know what exactly goes wrong, though. Care to explain? |
Contributor
|
This was superceded by #238. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simply switch the sources off, but keep them around so the event loop can discard
any unwanted events properly.
Fixes issue #163.