Skip to content

test: run test-nss-users/hosts by default#21946

Closed
yuwata wants to merge 1 commit intosystemd:mainfrom
yuwata:test-nss
Closed

test: run test-nss-users/hosts by default#21946
yuwata wants to merge 1 commit intosystemd:mainfrom
yuwata:test-nss

Conversation

@yuwata
Copy link
Copy Markdown
Member

@yuwata yuwata commented Dec 31, 2021

Prompted by #21935 (comment).

@thesamesam
Copy link
Copy Markdown
Contributor

thesamesam commented Dec 31, 2021

Excellent news: without #21944, the test suite fails on sparc at least (we're yet to see if the sanitizers in CI would pick it up though):

616/648 test-nss-hosts                            OK               5.28s
617/648 test-nss-users                            FAIL             5.24s   killed by signal 10 SIGBUS
>>> PATH=/var/tmp/portage/sys-apps/systemd-250-r1/work/systemd-250-.sparc64:/var/tmp/portage/sys-apps/systemd-250-r1/temp/python3.9/bin:/usr/lib/portage/python3.9/ebuild-helpers/xattr:/usr/lib/portage/p
ython3.9/ebuild-helpers:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/opt/bin MALLOC_PERTURB_=163 SYSTEMD_LANGUAGE_FALLBACK_MAP=/var/tmp/portage/sys-apps/systemd-250-r1/work/systemd-250/
src/locale/language-fallback-map /var/tmp/portage/sys-apps/systemd-250-r1/work/systemd-250-.sparc64/test-nss-users

The test suite passed before, modulo 2 harmless looking failures which I think are caused by the build environment. So even if we're not yet running with sanitizers, this is an improvement because at least we could've picked it up when running the suite in Gentoo.

EDIT: ... and CI failed too 🥳

[],
[libdl],
[], 'ENABLE_NSS', 'manual'],
[], 'ENABLE_NSS'],
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yuwata I'd wait for @keszybz to weigh in. I'm still not sure why those tests were "manual".

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at https://the-real-systemd.semaphoreci.com/jobs/f966d40a-b3c7-4414-a741-684d7df60e1b where the tests failed with

 FAIL: test-nss-hosts18:06
======== myhostname ========18:06
Failed to load module myhostname: libnss_myhostname.so.2: cannot open shared object file: No such file or directory
======== mymachines ========19:06
Failed to load module mymachines: libnss_mymachines.so.2: cannot open shared object file: No such file or directory

It seems they need polishing

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably test suite should set LD_LIBRARY_PATH variable pointing to directory with locally built libnss_myhostname.so.2 and libnss_mymachines.so.2.

@evverx
Copy link
Copy Markdown
Contributor

evverx commented Dec 31, 2021

@yuwata I hopefully fixed those tests in #21778.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

4 participants