nss-systemd: fix required buffer size calculation#21938
Merged
yuwata merged 1 commit intosystemd:mainfrom Dec 30, 2021
Merged
Conversation
This also fixes the pointer assigned to the gr_mem element of struct group. Fixes a bug introduced by 47fd7fa. Fixes systemd#21935.
Member
Author
|
This needs to be backported to v250-stable, v249-stable, and v248-stable. |
|
Problematic commit was also backported to branch v248-stable. |
bluca
reviewed
Dec 30, 2021
| dest->gr_name = buffer; | ||
| dest->gr_passwd = stpcpy(dest->gr_name, src->gr_name) + 1; | ||
| dest->gr_mem = (char **) strcpy(dest->gr_passwd, src->gr_passwd) + 1; | ||
| dest->gr_mem = (char **) stpcpy(dest->gr_passwd, src->gr_passwd) + 1; |
Member
Author
There was a problem hiding this comment.
I guess this did not work. We do not have enough tests for nss modules...
bluca
approved these changes
Dec 30, 2021
Member
Author
Oh. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also fixes the pointer assigned to the gr_mem element of struct group.
Fixes a bug introduced by 47fd7fa.
Fixes #21935.