Skip to content

ci: try to fix a Dependabot error #21342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mrc0mmand merged 2 commits into from
Nov 13, 2021
Merged

ci: try to fix a Dependabot error #21342

mrc0mmand merged 2 commits into from
Nov 13, 2021

Conversation

@evverx
Copy link
Contributor

@evverx evverx commented Nov 12, 2021

It was reported in https://github.com/systemd/systemd/network/updates

updater | ERROR <job_232492775> Error processing actions/checkout (RuntimeError)
updater | ERROR <job_232492775> No files changed!
updater | ERROR <job_232492775> /home/dependabot/dependabot-updater/vendor/ruby/2.7.0/gems/dependabot-github_actions-0.166.0/lib/dependabot/github_actions/file_updater.rb:28:in `updated_dependency_files'
updater | ERROR <job_232492775> /home/dependabot/dependabot-updater/lib/dependabot/updater.rb:676:in `generate_dependency_files_for'
updater | ERROR <job_232492775> /home/dependabot/dependabot-updater/lib/dependabot/updater.rb:274:in `check_and_create_pull_request'
updater | ERROR <job_232492775> /home/dependabot/dependabot-updater/lib/dependabot/updater.rb:82:in `check_and_create_pr_with_error_handling'
updater | ERROR <job_232492775> /home/dependabot/dependabot-updater/lib/dependabot/updater.rb:56:in `block in run'
updater | ERROR <job_232492775> /home/dependabot/dependabot-updater/lib/dependabot/updater.rb:56:in `each'
updater | ERROR <job_232492775> /home/dependabot/dependabot-updater/lib/dependabot/updater.rb:56:in `run'
updater | ERROR <job_232492775> /home/dependabot/dependabot-updater/lib/dependabot/update_files_job.rb:17:in `perform_job'
updater | ERROR <job_232492775> /home/dependabot/dependabot-updater/lib/dependabot/base_job.rb:28:in `run'
updater | ERROR <job_232492775> bin/update_files.rb:21:in `<main>`

I pushed this commit to my fork. Dependabot successfully extracted build_test.yml and opened evverx#25

@mrc0mmand could you take a look? The SHA points to v2.3.5: https://github.com/actions/checkout/releases/tag/v2.3.5

@evverx
try to fix a Dependabot error
4e29623 
```
updater | ERROR <job_232492775> Error processing actions/checkout (RuntimeError)
updater | ERROR <job_232492775> No files changed!
updater | ERROR <job_232492775> /home/dependabot/dependabot-updater/vendor/ruby/2.7.0/gems/dependabot-github_actions-0.166.0/lib/dependabot/github_actions/file_updater.rb:28:in `updated_dependency_files'
updater | ERROR <job_232492775> /home/dependabot/dependabot-updater/lib/dependabot/updater.rb:676:in `generate_dependency_files_for'
updater | ERROR <job_232492775> /home/dependabot/dependabot-updater/lib/dependabot/updater.rb:274:in `check_and_create_pull_request'
updater | ERROR <job_232492775> /home/dependabot/dependabot-updater/lib/dependabot/updater.rb:82:in `check_and_create_pr_with_error_handling'
updater | ERROR <job_232492775> /home/dependabot/dependabot-updater/lib/dependabot/updater.rb:56:in `block in run'
updater | ERROR <job_232492775> /home/dependabot/dependabot-updater/lib/dependabot/updater.rb:56:in `each'
updater | ERROR <job_232492775> /home/dependabot/dependabot-updater/lib/dependabot/updater.rb:56:in `run'
updater | ERROR <job_232492775> /home/dependabot/dependabot-updater/lib/dependabot/update_files_job.rb:17:in `perform_job'
updater | ERROR <job_232492775> /home/dependabot/dependabot-updater/lib/dependabot/base_job.rb:28:in `run'
updater | ERROR <job_232492775> bin/update_files.rb:21:in `<main>`
```
@evverx
ci: allow Dependabot to open up to 2 PRs
38ac3ab 
Apparently version updates aren't always disabled on old forks,
which leads to new PRs opened there. To somewhat mitigate the
issue let's limit the number of PRs Dependabot can create.

It was reported in yuwata#2 (comment)
@evverx evverx added the ci label Nov 12, 2021
@yuwata yuwata mentioned this pull request Nov 13, 2021
Closed
@evverx
Copy link
Contributor Author

evverx commented Nov 13, 2021 •
edited
Loading

@yuwata I added another commit that hopefully should mitigate the issue with forks until I figure out how to fix it properly

ci: allow Dependabot to open up to 2 PRs
Apparently version updates aren't always disabled on old forks,
which leads to new PRs opened there. To somewhat mitigate the
issue let's limit the number of PRs Dependabot can create.

It was reported in yuwata#2 (comment)

@yuwata
Copy link
Member

yuwata commented Nov 13, 2021

@evverx Thanks!

@evverx evverx mentioned this pull request Nov 13, 2021
Closed
@mrc0mmand
Copy link
Member

mrc0mmand commented Nov 13, 2021

@yuwata I added another commit that hopefully should mitigate the issue with forks until I figure out how to fix it properly

ci: allow Dependabot to open up to 2 PRs Apparently version updates aren't always disabled on old forks, which leads to new PRs opened there. To somewhat mitigate the issue let's limit the number of PRs Dependabot can create.

It was reported in yuwata#2 (comment)

Hah, nice catch! Looks like CIs are happy as well, so LGTM, thanks!

@mrc0mmand mrc0mmand merged commit 66a4136 into systemd:main Nov 13, 2021
@mrc0mmand mrc0mmand mentioned this pull request Nov 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrc0mmand mrc0mmand mrc0mmand approved these changes

Assignees

No one assigned

Labels

ci

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@evverx @yuwata @mrc0mmand