Skip to content

Conversation

@poettering
Copy link
Member

No description provided.

Copy link
Member

@bluca bluca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bluca bluca added the good-to-merge/waiting-for-ci 👍 PR is good to merge, but CI hasn't passed at time of review. Please merge if you see CI has passed label Nov 12, 2021
user-record.[ch] are about the UserRecord JSON stuff, and the UID
allocation range stuff (i.e. login.defs handling) is a very different
thing, and complex enough on its own, let's give it its own c/h files.

No code changes, just some splitting out of code.
Either way we need these four values, let's simplify the code by keeping
only one const struct of this around.
It doesn't actually test any of the JSON stuff, hence name it
test-uid-alloc-range, since it tests the stuff from uid-alloc-range.
@poettering poettering force-pushed the uid-alloc-range-split branch from 3391e48 to b4d4596 Compare November 13, 2021 07:11
@poettering poettering merged commit a4e27f0 into systemd:main Nov 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good-to-merge/waiting-for-ci 👍 PR is good to merge, but CI hasn't passed at time of review. Please merge if you see CI has passed journal util-lib

Development

Successfully merging this pull request may close these issues.

2 participants