Skip to content

homed: automatic grow/shrink of LUKS home dirs #21253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bluca merged 7 commits into from
Nov 25, 2021
Merged

homed: automatic grow/shrink of LUKS home dirs #21253

bluca merged 7 commits into from
Nov 25, 2021

Conversation

@poettering
Copy link
Member

@poettering poettering commented Nov 5, 2021

This adds a major new feature to homed: automatic resize of home dirs on login, logout and regularly inbetween.

This should make the LUKS backend a lot more friendly to multi-user scenarios as the disk size isn't statically assigned to home dirs anymore, but we can dynamically shrink and grow them whenever needed.

@poettering poettering added new-feature homed homed, homectl, pam_homed labels Nov 5, 2021
@poettering
Copy link
Member Author

poettering commented Nov 5, 2021

(this is not ready to be merged yet, still needs docs + more tests)

@poettering poettering linked an issue Nov 5, 2021 that may be closed by this pull request
homectl support for additional or arbitrary mount options #15120
Closed
@lgtm-com
Copy link

lgtm-com bot commented Nov 5, 2021

This pull request introduces 1 alert when merging 0a19583 into d874a13 - view on LGTM.com

new alerts:

  • 1 for Comparison result is always the same

@poettering poettering force-pushed the homed-auto-grow-shrink branch from 0a19583 to b0984e0 Compare November 5, 2021 21:03
@poettering poettering added this to the v250 milestone Nov 12, 2021
@poettering poettering force-pushed the homed-auto-grow-shrink branch from b0984e0 to 091daaa Compare November 12, 2021 16:21
This was referenced Nov 12, 2021
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@poettering poettering force-pushed the homed-auto-grow-shrink branch from 091daaa to d0b8a5e Compare November 12, 2021 17:39
@bluca
Copy link
Member

bluca commented Nov 12, 2021

Can some tests covering the new functionality be added?

@poettering poettering force-pushed the homed-auto-grow-shrink branch 2 times, most recently from 456313c to eea292a Compare November 15, 2021 14:51
@poettering poettering mentioned this pull request Nov 16, 2021
Merged
@poettering poettering force-pushed the homed-auto-grow-shrink branch 2 times, most recently from 42cd3fa to 3faef01 Compare November 16, 2021 23:44
This was referenced Nov 17, 2021
Merged
Merged
@poettering poettering force-pushed the homed-auto-grow-shrink branch from 3faef01 to 6e99078 Compare November 19, 2021 09:12
@poettering poettering mentioned this pull request Nov 19, 2021
Merged
@bluca
Copy link
Member

bluca commented Nov 23, 2021

anything left to do here or has it all been merged via split PRs?

@poettering poettering force-pushed the homed-auto-grow-shrink branch from 6e99078 to 4347b7a Compare November 23, 2021 17:25
@poettering
Copy link
Member Author

poettering commented Nov 23, 2021

anything left to do here or has it all been merged via split PRs?

Yes. There's one thing still missing from the stuff that got merged: automatic rebalancing of free space between active homes. I have rebase that code now and added the docs, and repushed.

Will work on a test case too. Once that's done it's the last thing to review/merge on this topic.

@bluca
Copy link
Member

bluca commented Nov 25, 2021

some minor comments - also is it documented anywhere why this is only supported for LUKS?

The other backends allocate files from a common pool anyway. Only the LUKS2 backend has per-user file systems that need to resized to make free space available from the underlying file system. will add a comment to the man page about that.

Got it, thanks

@poettering poettering force-pushed the homed-auto-grow-shrink branch 2 times, most recently from bcdb81a to 4cc8aad Compare November 25, 2021 17:17
@poettering
Copy link
Member Author

poettering commented Nov 25, 2021

force pushed a new version, with all raised points addressed. ptal

@poettering poettering added please-review and removed reviewed/needs-rework 🔨 PR has been reviewed and needs another round of reworks labels Nov 25, 2021
bluca
bluca approved these changes Nov 25, 2021
View reviewed changes
Copy link
Member

@bluca bluca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, needs rebase

@bluca bluca added good-to-merge/waiting-for-ci 👍 PR is good to merge, but CI hasn't passed at time of review. Please merge if you see CI has passed needs-rebase and removed please-review labels Nov 25, 2021
@poettering poettering force-pushed the homed-auto-grow-shrink branch from 4cc8aad to 6d975fe Compare November 25, 2021 17:28
@poettering
Copy link
Member Author

poettering commented Nov 25, 2021

rebased

@poettering
Copy link
Member Author

poettering commented Nov 25, 2021

ubuntu CI failed, but its HOMED test suceeded, so we are good. yay!

@bluca bluca merged commit 485c9e1 into systemd:main Nov 25, 2021
@keszybz keszybz mentioned this pull request Dec 16, 2021
Closed
@mbiebl
Copy link
Contributor

mbiebl commented Dec 16, 2021

ubuntu CI failed, but its HOMED test suceeded, so we are good. yay!

hm, the Ubunt CI builds with -Dhomed=false unless I'm mistaken and the HOMED test is a nop

@mbiebl
Copy link
Contributor

mbiebl commented Dec 16, 2021 

# Check if homectl is installed, and if it isn't bail out early instead of failing
if ! test -x /usr/bin/homectl ; then
        echo OK >/testok
        exit 0
fi

Shouldn't this return "skipped" instead?

@bluca
Copy link
Member

bluca commented Dec 16, 2021

yeah, probably

mbiebl added a commit to mbiebl/systemd that referenced this pull request Dec 16, 2021
@mbiebl
test: mark TEST-46-HOMED as skipped if feature is disabled
4d35d4a 
See systemd#21253 (comment)
@mbiebl mbiebl mentioned this pull request Dec 16, 2021
Merged
bluca pushed a commit that referenced this pull request Dec 16, 2021
@mbiebl @bluca
test: mark TEST-46-HOMED as skipped if feature is disabled
5c18815 
See #21253 (comment)
@mbiebl mbiebl mentioned this pull request Dec 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bluca bluca bluca approved these changes

+1 more reviewer

@behrmann behrmann behrmann left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

documentation good-to-merge/waiting-for-ci 👍 PR is good to merge, but CI hasn't passed at time of review. Please merge if you see CI has passed homed homed, homectl, pam_homed new-feature

Milestone

v250

Development

Successfully merging this pull request may close these issues.

homectl support for additional or arbitrary mount options

4 participants

@poettering @bluca @mbiebl @behrmann