resolve: fix use after free in DnsAnswer#18135
Merged
mrc0mmand merged 1 commit intosystemd:masterfrom Jan 8, 2021
Merged
Conversation
bluca
reviewed
Jan 5, 2021
bluca
reviewed
Jan 5, 2021
Member
|
@mrc0mmand if you have a reliable reproducer, could you please check this patch, if you have time? |
Member
Unfortunately I don't, this issue happened quite randomly across several runs in the past couple of days. |
poettering
requested changes
Jan 6, 2021
8041cdb to
25e9a02
Compare
Member
Author
|
@poettering and @bluca Thank you for the review. Force-pushed a new version. PTAL. |
poettering
reviewed
Jan 8, 2021
This fixes a bug introduced by ae45e1a. The set DnsAnswer::set_items contains the reference to the array in DnsAnswer. So, the set must be reconstructed when we realloc() the object. Fixes systemd#18132.
25e9a02 to
b863809
Compare
Member
Author
|
@poettering Thank you for your comment. The comment is updated. Setting the green label. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug introduced by ae45e1a.
Fixes #18132.