shared/dns: fix dlopen_idn return code check #18093
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
tested by building minimal image with mkosi, booting it in nspawn, moving away libidn* from /usr/lib/arch and restarting resolved. Before the fix |
Member
|
LGTM. |
Member
|
ouch! thanks for the quick fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18078
Returning -EALREADY in case the idna name cannot be resolved is already supported and supposed to be optional.
Call stack:
https://github.com/systemd/systemd/blob/1835a8a1055/src/resolve/resolved-dns-question.c#L285
https://github.com/systemd/systemd/blob/1835a8a1055/src/resolve/resolved-bus.c#L406