network: fix IPv6PrivacyExtensions=kernel #18069
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IPv6 privacy extensions are plural, not singular.
Contributor
Author
|
I verified this by running the NixOS networkd privacy test ( |
When set to "kernel", systemd is not supposed to touch that sysctl. 5e0534f, part of systemd#17240 forgot to handle that case. Fixes systemd#18003
175ce3f to
d3ccb1b
Compare
Member
|
Thanks. I fixed the reference to the commit 5e0534f in the message of the second commit. |
Contributor
Author
|
Thanks. It'd be nice if this could get backported to 247.x. |
Contributor
Author
|
poke @keszybz - can this be cherry-picked for 247.3? |
|
A month of people unknowingly exposing a non-private ipv6 address. What could possibly go wrong? |
Member
|
Backport PR is created: systemd/systemd-stable#86 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When set to "kernel", systemd is not supposed to touch that sysctl.
5e0534f, part of #17240 forgot to handle that case.
Fixes #18003
cc @keszybz @yuwata