Skip to content

networkd: ndisc - add support for prefix allow-list and route allow-list #18021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yuwata merged 8 commits into from
Dec 24, 2020
Merged

networkd: ndisc - add support for prefix allow-list and route allow-list #18021

yuwata merged 8 commits into from
Dec 24, 2020

Conversation

@ssahani
Copy link
Contributor

@ssahani ssahani commented Dec 18, 2020

It requires a testing /. will do that.

bluca
bluca reviewed Dec 21, 2020
View reviewed changes
@bluca
Copy link
Member

bluca commented Dec 21, 2020

It requires a testing /. will do that.

Have you done the testing now?

@ssahani
Copy link
Contributor Author

ssahani commented Dec 22, 2020

It requires a testing /. will do that.

Have you done the testing now?

On vacation goa india away from kb. Sorry will do .

@bluca
Copy link
Member

bluca commented Dec 22, 2020

It requires a testing /. will do that.

Have you done the testing now?

On vacation goa india away from kb. Sorry will do .

No problem at all and no rush, just checking. Enjoy your vacation!

@yuwata
Copy link
Member

yuwata commented Dec 24, 2020 •
edited
Loading

I force-pushed to add a fix for memleak. I will also add a test case for this later. So, please do not merge this yet.

@yuwata
Copy link
Member

yuwata commented Dec 24, 2020

@ssahani and @bluca I added several tests for the new settings. While that, I found several issues, and the fixes for them are also included in this PR now. Furthermore, I added RouterAllowList= and RouterDenyList=. PTAL.

@yuwata yuwata force-pushed the route-allow-list branch 2 times, most recently from 9806d06 to 5a81e9a Compare December 24, 2020 05:41
@bluca bluca added good-to-merge/waiting-for-ci 👍 PR is good to merge, but CI hasn't passed at time of review. Please merge if you see CI has passed and removed needs-review labels Dec 24, 2020
@yuwata yuwata merged commit b945573 into systemd:master Dec 24, 2020
@ssahani ssahani deleted the route-allow-list branch December 25, 2020 13:29
@ssahani
Copy link
Contributor Author

ssahani commented Dec 25, 2020

Thanks @bluca and @yuwata

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yuwata yuwata yuwata left review comments

@bluca bluca bluca approved these changes

Assignees

No one assigned

Labels

good-to-merge/waiting-for-ci 👍 PR is good to merge, but CI hasn't passed at time of review. Please merge if you see CI has passed network

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ssahani @bluca @yuwata