networkd: don't enable dhcpv6 on l3 devices#17608
Conversation
|
I also tried to come up with a test for this. However I don't have a fedora VM right now to test it: |
yuwata
left a comment
There was a problem hiding this comment.
I think link_ipv6ll_enabled() should be updated for such devices, instead of adding an extra condition in dhcp6_configure().
|
I am not sure |
|
Right now I consider issue a blocker for the next release because it will break VPN setups. |
Or, then |
|
I think, we should also update |
|
I cannot use |
As, RA may request to start dhcp6 client. So, please not only BTW, I noticed that |
|
And, half of the list of interface kind in |
|
Would this not break multi-cast network interfaces that support router advertisement but don't have MAC addresses? cc @andir UPDATE ok. let's go this route, but longterm it would be good not to depend on having ethernet for dhcpv6/router advertisment. |
|
Actually |
|
@yuwata it now defaults to |
9ee237f to
f80d043
Compare
Devices with multicast but without mac addresses i.e. tun devices
are not getting setuped correctly:
$ ip tuntap add mode tun dev tun0
$ ip addr show tun0
16: tun0: <NO-CARRIER,POINTOPOINT,MULTICAST,NOARP,UP> mtu 1500 qdisc fq_codel state DOWN group default qlen 500
link/none
$ cat /etc/systemd/network/tun0.network
[Match]
Name = tun0
[Network]
Address=192.168.1.1/32
$ ./systemd-networkd
tun0: DHCP6 CLIENT: Failed to set identifier: Invalid argument
tun0: Failed
|
Thanks. LGTM. |
keszybz
left a comment
There was a problem hiding this comment.
bionic-amd64 failed in TEST-50-DISSECT.
semaphoreci timed out.
I'll go ahead and merge this without waiting for the straggling tests, since this isn't tested in any way by our tests, so if some pass because compilation works, there isn't much point in waiting for the others.
| return &link->network->duid; | ||
| else if (link->hw_addr.length == 0 && | ||
| (link->manager->duid.type == DUID_TYPE_LLT || | ||
| link->manager->duid.type == DUID_TYPE_LL)) |
There was a problem hiding this comment.
IN_SET() would be nicer here, but it doesn't matter much.
Devices with multicast but without mac addresses i.e. tun devices
are not getting setuped correctly:
$ ip tuntap add mode tun dev tun0
$ ip addr show tun0
16: tun0: <NO-CARRIER,POINTOPOINT,MULTICAST,NOARP,UP> mtu 1500 qdisc fq_codel state DOWN group default qlen 500
link/none
$ cat /etc/systemd/network/tun0.network
[Match]
Name = tun0
[Network]
Address=192.168.1.1/32
$ ./systemd-networkd
tun0: DHCP6 CLIENT: Failed to set identifier: Invalid argument
tun0: Failed