meson: add option to skip installing to $sysconfdir#17580
Merged
keszybz merged 1 commit intosystemd:masterfrom Nov 12, 2020
Merged
meson: add option to skip installing to $sysconfdir#17580keszybz merged 1 commit intosystemd:masterfrom
keszybz merged 1 commit intosystemd:masterfrom
Conversation
This is useful for development where overwriting files out side the configured prefix will affect the host as well as stateless systems such as NixOS that don't let packages install to /etc but handle configuration on their own. Alternative to systemd#17501 tested with: $ mkdir inst build && cd build $ meson \ -Dcreate-log-dirs=false \ -Dsysvrcnd-path=$(realpath ../inst)/etc/rc.d \ -Dsysvinit-path=$(realpath ../inst)/etc/init.d \ -Drootprefix=$(realpath ../inst) \ -Dinstall-sysconfdir=false \ --prefix=$(realpath ../inst) .. $ ninja install
keszybz
reviewed
Nov 12, 2020
| input : file + '.in', | ||
| output : file, | ||
| configuration : substs, | ||
| install_dir : dir == 'no' ? '' : dir) |
Member
There was a problem hiding this comment.
I'd maybe prefer to fold the condition into install_dir here, something like:
install_dir = (install_sysconfdir or dir != pkgsysconfdir) and dir != 'no' ? dir : ''
cofnigure_file(
...
install_dir : install_dir)
but current version is also OK.
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is useful for development where overwriting files out side
the configured prefix will affect the host as well as stateless
systems such as NixOS that don't let packages install to /etc but handle
configuration on their own.
Alternative to #17501
tested with:
$ mkdir inst build && cd build
$ meson
-Dcreate-log-dirs=false
-Dsysvrcnd-path=$(realpath ../inst)/etc/rc.d
-Dsysvinit-path=$(realpath ../inst)/etc/init.d
-Drootprefix=$(realpath ../inst)
-Dinstall-sysconfdir=false
--prefix=$(realpath ../inst) ..
$ ninja install