Skip to content

turn libidn/libidn2 dep into dlopen() one #17292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
keszybz merged 2 commits into from
Oct 10, 2020
Merged

turn libidn/libidn2 dep into dlopen() one #17292

keszybz merged 2 commits into from
Oct 10, 2020

Conversation

@poettering
Copy link
Member

@poettering poettering commented Oct 9, 2020

I manually tested here that this compiles with libidn, with libidn2 and without either

bluca
bluca approved these changes Oct 9, 2020
View reviewed changes
Copy link
Member

@bluca bluca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keszybz keszybz merged commit 092f5d2 into systemd:master Oct 10, 2020
@flokli flokli mentioned this pull request Dec 24, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bluca bluca bluca approved these changes

Assignees

No one assigned

Labels

meson resolve util-lib

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@poettering @bluca @keszybz