Skip to content

network: tc: introduce ETS #16106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
poettering merged 3 commits into from
Jun 24, 2020
Merged

network: tc: introduce ETS #16106

poettering merged 3 commits into from
Jun 24, 2020

Conversation

@yuwata
Copy link
Member

@yuwata yuwata commented Jun 9, 2020

Closes #15264.

Not tested yet. Please don't merge this.

cc @k0ste and @ssahani.

poettering
poettering requested changes Jun 9, 2020
View reviewed changes
@ssahani
Copy link
Contributor

ssahani commented Jun 10, 2020 •
edited
Loading

I tested it.

root@arch /lib/systemd/network
❯ tc qdisc
qdisc noqueue 0: dev lo root refcnt 2
qdisc ets 1: dev ens192 root refcnt 5 bands 8 quanta 1514 1514 1514 1514 1514 1514 1514 1514 priomap 7 6 5 4 3 7 7 7 7 7 7 7 7 7 7 7
qdisc ets 3a: dev dummy98 root refcnt 2 bands 10 strict 3 quanta 1514 1514 1514 1514 1514 1514 1514 priomap 9 9 9 9 9 9 9 9 9 9 9 9 9 9 9 9

root@arch /lib/systemd/network
❯ cat dummy.network
[Match]
Name=dummy98

[Network]
IPv6AcceptRA=no
Address=10.1.2.3/16

[EnhancedTransmissionSelection]
Parent=root
Handle=3a
Band=10
Strict=3
Quanta=1 2 3 4 5
PriorityMap=3 4 5 6 7

[EnhancedTransmissionSelectionClass]
Parent=root
ClassId=3a:30
Quantum=4
root@arch /lib/systemd/network

/usr/lib/systemd/network/dummy.network:13: Failed to parse 'Quanta=', ignoring assignment: 1
/usr/lib/systemd/network/dummy.network:13: Failed to parse 'Quanta=', ignoring assignment: 2
/usr/lib/systemd/network/dummy.network:13: Failed to parse 'Quanta=', ignoring assignment: 3
/usr/lib/systemd/network/dummy.network:13: Failed to parse 'Quanta=', ignoring assignment: 4
/usr/lib/systemd/network/dummy.network:13: Failed to parse 'Quanta=', ignoring assignment: 5
/usr/lib/systemd/network/dummy.network:14: Failed to parse 'PriorityMap=', ignoring assignment: 3
/usr/lib/systemd/network/dummy.network:14: Failed to parse 'PriorityMap=', ignoring assignment: 4
/usr/lib/systemd/network/dummy.network:14: Failed to parse 'PriorityMap=', ignoring assignment: 5
/usr/lib/systemd/network/dummy.network:14: Failed to parse 'PriorityMap=', ignoring assignment: 6

@yuwata
Copy link
Member Author

yuwata commented Jun 10, 2020

Oh, thank you for testing.

@yuwata yuwata added the reviewed/needs-rework 🔨 PR has been reviewed and needs another round of reworks label Jun 10, 2020
@yuwata yuwata removed the reviewed/needs-rework 🔨 PR has been reviewed and needs another round of reworks label Jun 17, 2020
@yuwata
Copy link
Member Author

yuwata commented Jun 17, 2020

Updated. Now configs are renamed

  • Band= -> Bands=
  • Strict= -> StrictBands=
  • Quantum= -> QuantumBytes=

And parser errors are fixed.
@ssahani Could you test this PR?

@poettering How should we name the setting Quanta=? It is a list of bytes.

@ssahani
Copy link
Contributor

ssahani commented Jun 17, 2020

yes this one OK

❯ tc qdisc
qdisc ets 3a: dev dummy98 root refcnt 2 bands 10 strict 3 quanta 1 2 3 4 5 1514 1514 priomap 3 4 5 6 7 9 9 9 9 9 9 9 9 9 9 9

@yuwata yuwata force-pushed the network-tc-ets branch 2 times, most recently from 88656b1 to ae8d801 Compare June 18, 2020 05:48
@yuwata
Copy link
Member Author

yuwata commented Jun 18, 2020

Quanta= is simply renamed to QunatumBytes= and the document is updated to mention it takes a list.

@poettering poettering merged commit f9044b7 into systemd:master Jun 24, 2020
@yuwata yuwata deleted the network-tc-ets branch June 25, 2020 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@poettering poettering poettering requested changes

Assignees

No one assigned

Labels

network

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

network: tc: add sch_ets qdisc

3 participants

@yuwata @ssahani @poettering