Skip to content

network: read driver name from ethtool #16054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
poettering merged 1 commit into from
Jun 3, 2020
Merged

network: read driver name from ethtool #16054

poettering merged 1 commit into from
Jun 3, 2020

Conversation

@yuwata
Copy link
Member

@yuwata yuwata commented Jun 3, 2020

Closes #15678.

@yuwata yuwata added the network label Jun 3, 2020
@yuwata yuwata mentioned this pull request Jun 3, 2020
Closed
@keszybz
Copy link
Member

keszybz commented Jun 3, 2020

Looks reasonable, but could you add a longer explanation what is happenning and what the effect this has in the commit message?

@yuwata
network: read driver name from ethtool
d8a1f28 
To make Driver= in [Match] section work in containers.

Note that ID_NET_DRIVER= property in udev database is set with the
result of the ethtool. So, this should not change anything for
non-container cases.

Closes systemd#15678.
@yuwata yuwata force-pushed the network-use-ethtool-for-driver-15678 branch from 82ef5f2 to d8a1f28 Compare June 3, 2020 08:31
@yuwata
Copy link
Member Author

yuwata commented Jun 3, 2020

Looks reasonable, but could you add a longer explanation what is happenning and what the effect this has in the commit message?

Sure. Updated. PTAL.

@poettering poettering added good-to-merge/waiting-for-ci 👍 PR is good to merge, but CI hasn't passed at time of review. Please merge if you see CI has passed and removed good-to-merge/with-minor-suggestions labels Jun 3, 2020
@poettering
Copy link
Member

poettering commented Jun 3, 2020

perfect!

@poettering poettering merged commit c643bda into systemd:master Jun 3, 2020
@yuwata yuwata deleted the network-use-ethtool-for-driver-15678 branch June 3, 2020 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

good-to-merge/waiting-for-ci 👍 PR is good to merge, but CI hasn't passed at time of review. Please merge if you see CI has passed network

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

networkd inside of containers cannot do Driver= matches in .network files, since udev doesn't run in containers

3 participants

@yuwata @keszybz @poettering